Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert comments to doxygen #76

Merged
merged 5 commits into from
Mar 7, 2022
Merged

Convert comments to doxygen #76

merged 5 commits into from
Mar 7, 2022

Conversation

digama0
Copy link
Member

@digama0 digama0 commented Mar 7, 2022

This will conflict with #75 to some extent, but I think it will be helpful for @wlammen to work from a base in which most functions are already (poorly) doxygen'd. In particular, the new doxygen comments should include or incorporate all of the text from the original documentation; there were some cases like temp_vstring or the mmvstr.h header where sizable comments were ignored when the doxygen comment was added, resulting in two comments with different syntax and somewhat overlapping contents.

@wlammen
Copy link
Contributor

wlammen commented Mar 7, 2022

I am fine with that. For one I learn a few techniques new to me, on the other hand it makes the documentation more useful for a wider audience.

I envision a few merge conflicts with PR #75. Other than that there is no real trouble, since code is not affected, only documentation.

Copy link
Contributor

@wlammen wlammen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only documentation is affected, no code change

@digama0 digama0 merged commit c1d7148 into master Mar 7, 2022
@digama0 digama0 deleted the doxy_convert branch March 7, 2022 19:18
@jkingdon
Copy link
Collaborator

work from a base in which most functions are already (poorly) doxygen'd

Surely the verb form of that should be "doxygenated"? 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants