improve axiom detection heuristic in axiom_use.rs #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirix
reviewed
Jun 15, 2024
| db.write_stmt_use( | ||
| |sref| { | ||
| sref.statement_type() == StatementType::Axiom | ||
| && sref.proof_slice_at(0) == b"|-" |
There was a problem hiding this comment.
Why not use the $j syntax '|-' as 'wff'; hint?
There was a problem hiding this comment.
Possibly the instant motivation was that set.mm/miu.mm also uses the popular token |- but doesn't have any $j comments or distinguish the introduction of new non-syntax/non-definition rules with labels that begin with ax-, so this meant to be an incremental improvement with respect to the set.mm databases/examples in the Metamath book.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue mentioned in #160: instead of using
ax-to detect axioms, use non-syntax axioms which do not start withdf-.