dump formulas in source order #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirix
reviewed
Oct 28, 2024
Comment on lines
+1743
to
+1745
| let Some(formula) = sps.formulas.get(&sref.address()) else { | ||
| continue; | ||
| }; |
There was a problem hiding this comment.
Shouldn't we .unwrap() instead of else { continue; } ?
A formula stored in the wrong segment is an internal bug which should not be just ignored IMO.
There was a problem hiding this comment.
No, I think this one is a continue because sref is looping over all statements, including comments, $d declarations, and other random junk. Presumably only some of them actually have formulas associated to them. If you prefer we could do some other check like is_statement() to guard the continue and then assert everything that remains is in sps.formulas.
|
I agree with the principle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Printing in hashmap order is bad because it is both visibly random and also nondeterministic.