WIP: Add support for collection options #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abunashir
force-pushed
the
collection-options
branch
from
e194dc2
to
b51b162
Compare
|
FYI the Collection documentation is here: For testing, you can use the BIPM SI Brochure which is already a collection, but site generation doesn't work: |
abunashir
force-pushed
the
collection-options
branch
from
43e5468
to
b63c9b8
Compare
abunashir
force-pushed
the
collection-options
branch
from
b63c9b8
to
6200b81
Compare
abunashir
force-pushed
the
collection-options
branch
from
6200b81
to
de00fa4
Compare
abunashir
force-pushed
the
collection-options
branch
from
b859ead
to
fca75c4
Compare
|
@abunashir is this task ready to go? Thanks. |
|
Hi @ronaldtse: Not yet, I'm crating sub pull requests and once those are resolved then we can close this one. |
|
Closing this one in favour of #260 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work In Progress!
On the site generator configuration: we want to add an option/field, where a user can provide collection file as configuration.
During site generation, we want the generator to take this into consideration and based on this we also want to the site generator to invoke the collection building happening.
In the collection interface, we also want to support configuration options, instead of passing around we also want to be specified in form of data filed and use that one to pass it down to the metanorma xml
Todos
Related: #205