Fetch and parse NIST documents using relaton-nist fetcher and parser #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mico
force-pushed
the
allrecords-new-schema
branch
from
3eb525b to
b30cfc6
Compare
andrew2net
reviewed
Nov 3, 2024
| .xpath("/body/query/doi_record/report-paper/report-paper_metadata") | ||
| .map { |doc| parse_docid doc } | ||
| LocMods::Collection.from_xml(OpenURI.open_uri(URL)).mods.map do |doc| | ||
| url = doc.location.reduce(nil) { |m, l| m || l.url.detect { |u| u.usage == "primary display" } } |
There was a problem hiding this comment.
Can we have class methods that parses title and DOI outside the loop? So these methods could be used in relaton-nist
Pubid::List::NistTechPubs.parse_doi(doc) => "NIST.IR.841"
Pubid::List::NistTechPubs.parse_title(doc) => "Status report ..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #233