Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MTG-331]feat :additional tests #33

Merged
merged 7 commits into from
Oct 3, 2024
Merged

[MTG-331]feat :additional tests #33

merged 7 commits into from
Oct 3, 2024

Conversation

RequescoS
Copy link
Contributor

No description provided.

@RequescoS RequescoS changed the title feat :additional tests [MTG-331]feat :additional tests Sep 16, 2024
@kstepanovdev kstepanovdev changed the base branch from master to main September 16, 2024 11:12
StanChe
StanChe approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@StanChe StanChe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@RequescoS
Merge remote-tracking branch 'origin/main' into feat/additional-tests
1c426e2 
# Conflicts:
#	programs/mpl-staking/src/instructions/claim.rs
#	programs/mpl-staking/tests/test_claim.rs
@RequescoS
merge
4444b74
@RequescoS
fmt
2ae7c4d
kstepanovdev
kstepanovdev reviewed Oct 3, 2024
View reviewed changes
programs/mpl-staking/tests/test_claim.rs Outdated
&vote_record,
)
.await
.assert_on_chain_err(MplStakingError::TokenflowRestricted);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik claiming will return errors from the Staking. i guess rewards even doesn't have such errors.

kstepanovdev
kstepanovdev reviewed Oct 3, 2024
View reviewed changes
programs/mpl-staking/tests/test_claim.rs Outdated
)
.await?;
.await
.expect_err("Claiming is restricted by Rewards program");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it? Probably, the staking itself should return errors.

kstepanovdev
kstepanovdev requested changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@kstepanovdev kstepanovdev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome changes. However, we might want to catch specific errors instead of capturing some errors that occurred in general if it's possible.

kstepanovdev
kstepanovdev approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@kstepanovdev kstepanovdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the refactoring.

@RequescoS RequescoS merged commit 4156294 into main Oct 3, 2024
2 checks passed
@RequescoS RequescoS deleted the feat/additional-tests branch October 3, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstepanovdev kstepanovdev kstepanovdev approved these changes

@StanChe StanChe StanChe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RequescoS @StanChe @kstepanovdev