[MTG-758] [MTG-802] Rectify close_voter ix #41
Conversation
kstepanovdev
force-pushed
the
audit-fixes-round-3
branch
from
4bf71b5 to
da0769f
Compare
There was a problem hiding this comment.
With this change we definitely need to document, what should be sent. It's quite counterintuitive to pass in all the possible associated token accounts. Also extending the number of voting mints might make closing the registrar nearly impossible, but that's smth we should just write in comments. Also I'd say we should restrict the positions of the accounts being closed. So we have several voting mints that are not zeroed. And the first remaining account should be for the first non-zeroed voting mint. The second - for the second and so on. This way may have a linear complexity instead of quadratic.
… reduce computations complexity
kstepanovdev
changed the title
|
|
||
| for (index, calculated_ata_to_close) in calculated_atas_to_close.enumerate() { | ||
| require!( |
There was a problem hiding this comment.
We've already checked this before. What might have changed?
There was a problem hiding this comment.
Tunnel vision. Thanks!
To close
voterand itsATAan end-user need to pass in allATAgathered from mints of aRegistrar; even if thoseATAdon't exist, their addresses may still be calculated.