Refactor and bugfixing #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[MTG-234] calculate weighted stake
…eration instead of withdraw
StanChe
reviewed
Jul 8, 2024
StanChe
reviewed
Jul 8, 2024
| /// * `max_extra_lockup_vote_weight_scaled_factor`: max extra weight for lockups, in 1/1e9 units | ||
| /// * `lockup_saturation_secs`: lockup duration at which the full vote weight bonus is given to | ||
| /// locked up deposits | ||
| /// * `grand_authority`: The keypair that might be an authority for Grand/Clawback |
There was a problem hiding this comment.
It's Grant
Suggested change
| /// * `grand_authority`: The keypair that might be an authority for Grand/Clawback | |
| /// * `grant_authority`: The keypair that might be an authority for the Grant/Clawback operation |
There was a problem hiding this comment.
Ahah, sure. Didn't notice
| /// * B with digit_shift=0, baseline_vote_weight_scaled_factor=1e9, | ||
| /// max_extra_lockup_vote_weight_scaled_factor=1e9 | ||
| /// to not lose precision on B tokens. | ||
| /// The vote weight for `amount` of native tokens will be 1:1. Therefore, all active |
There was a problem hiding this comment.
The comment for this method is a bit misleading.
Creates a new exchange rate for a given mint. This allows a voter to ...
doesn't reflect the nature of registering the token that may be used in staking lockups and for voting. This may be both the community and the governance tokens. (Am I getting this last part right?) The operation also persists the grant authority for the specified mint, that will be able to provide grants to other users and may clawback those if the grant terms are violated
| @@ -115,14 +99,12 @@ pub fn withdraw( | |||
|
|
|||
| // Governance may forbid withdraws, for example when engaged in a vote. | |||
| // Not applicable for tokens that don't contribute to voting power. | |||
There was a problem hiding this comment.
This part of the comment is irrelevant to our implementation and should be removed
…-deposit-authority-signature MGT-345: Initialize rewards-pool deposit authority signature
…extend_stake-operations Kstepanov/mtg 398 unify stake extend stake operations
fixed weighted_stake function, added tests
* update spl_governance to 3.1.1 * update governance * refactor dependencies
…nto devnet-version
…eration instead of withdraw
* update spl_governance to 3.1.1 * update governance * refactor dependencies
…taking into refactor-and-bugfixing
improved error handling
* initial delegate * add delegate initial design * update tests * update tests && fixtures * initial delegate * add delegate initial design * update fixtures * remove redundant reprs * store deposit mining on each creation of deposit entry && add additional validations for stake and extend methods * update tests * remove redundant file * mtg-425: Error handling improvements (#14) improved error handling * initial delegate * add delegate initial design * update tests * update tests && fixtures * initial delegate * add delegate initial design * update fixtures * remove redundant reprs * store deposit mining on each creation of deposit entry && add additional validations for stake and extend methods * update tests * remove redundant file * add delegate as a dedicated wallet instead of delegate_mining * Update program-states/src/state/deposit_entry.rs Co-authored-by: Stanislav Cherviakov <[email protected]> * Update programs/voter-stake-registry/src/cpi_instructions.rs Co-authored-by: Stanislav Cherviakov <[email protected]> * unify mining verification * simplify mining verification * [mtg-308] (#15) * added change delegate function * Fixes after rebase * fix aligment * Update program-states/src/state/deposit_entry.rs Co-authored-by: Stanislav Cherviakov <[email protected]> --------- Co-authored-by: Stanislav Cherviakov <[email protected]> --------- Co-authored-by: Matiukhin Vlad <[email protected]> Co-authored-by: Stanislav Cherviakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.