MGT-345: Initialize rewards-pool deposit authority signature #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstepanovdev
reviewed
Jul 9, 2024
| @@ -24,12 +24,11 @@ pub enum RewardsInstruction { | |||
| /// [R] Reward mint account | |||
| /// [W] Vault account | |||
| /// [WS] Payer | |||
| /// [R] Rent sysvar | |||
| /// [WS] Deposit authority account | |||
There was a problem hiding this comment.
Haven't we agreed that it should be just S?
kstepanovdev
reviewed
Jul 9, 2024
| fill_authority: Pubkey, | ||
| distribution_authority: Pubkey, | ||
| rent: AccountInfo<'a>, |
There was a problem hiding this comment.
Please, put rent just after deposit_authority everywhere
kstepanovdev
reviewed
Jul 9, 2024
| registrar.realm = ctx.accounts.realm.key(); | ||
| registrar.realm_governing_token_mint = ctx.accounts.realm_governing_token_mint.key(); | ||
| registrar.realm_authority = ctx.accounts.realm_authority.key(); | ||
| let signers_seeds = { |
There was a problem hiding this comment.
please, leave a describing comment here. It looks strange that signers_seeds includes all the operations below. I just showed this as an example. Also, you may want to redeclare the block or do sth else.
|
LGTM |
kstepanovdev
deleted the
MGT-345-Initialize-rewards-pool-deposit-authority-signature
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.