-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bubblegum Update Metadata Version 2 #135
Changes from all commits
09a599d
5ef2eb9
7dcf74b
2084aa7
269bf0d
bdf8e3c
0240ce5
c26c693
dd891e8
97fe275
660a6ba
213dac5
026c16a
e797adc
f2b1218
77020fa
5c15538
ccc9257
2077511
a2999e2
d817795
30d83ea
c7028bb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,7 +22,7 @@ pub struct Model { | |
pub seq: i64, | ||
pub level: i64, | ||
pub hash: Vec<u8>, | ||
pub created_at: Option<DateTime>, | ||
pub created_at: DateTime, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same as above , does this need a migration since it has changed from option There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I have same response. If you look at |
||
pub tx: String, | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need a migration to set the default value for thid? since this used to be optional we might have null values in. db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at
m20230720_120101_add_asset_grouping_verified.rs
it was not nullable from that point. All I did for this was regenerate the SeaORM objects based on the existing migrations. Do we need a special migration to check whether people have it as Optional in their databases? My guess is that it wasn't ever nullable and the SeaORM was somehow not updated?