Add showFungible option flag to das #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Nagaprasadvr
commented
Nov 14, 2024
•
Nagaprasadvr
commented
- add showFungible flag to options which will be used by getAsset, getAssetsByOwner etc
- impl showFungible - match assets which are either fungibleToken or fungibleAsset
Nagaprasadvr
changed the title
Merged
4 tasks
kespinola
requested changes
Nov 20, 2024
3 tasks
kespinola
requested changes
Nov 27, 2024
...ts/integration_tests__show_fungible_flag_tests__get_asset_with_show_fungible_scenario_1.snap
Outdated
Show resolved
Hide resolved
danenbm
reviewed
Dec 27, 2024
integration_tests/tests/integration_tests/show_fungible_flag_tests.rs
Outdated
Show resolved
Hide resolved
danenbm
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
This LGTM. After I approve everything I'm also going to ask Helius to take a look at all these before we merge them into main. It might be good to just combine 214 and 215 in some way so that same content needs to be reviewed twice by them.
Or maybe its just as simple as I will let them know 214 already contained in 215.
kespinola
force-pushed
the
das-46-show-fungibles-rpc-option
branch
2 times, most recently
from
b1de06c to
e436a14
Compare
kespinola
approved these changes
Jan 6, 2025
| asset_data.one(conn).await.and_then(|o| match o { | ||
| Some((a, d)) => Ok((a, d)), | ||
| Some((a, Some(d))) => Ok((a, d)), |
There was a problem hiding this comment.
This change now enforces that DAS will only return an asset when its metadata data info is also available. For fungibles this means DAS will return not fund unless the mint has associated metadata account , metadata pointer (for token extensions), core single account asset.
kespinola
force-pushed
the
das-46-show-fungibles-rpc-option
branch
4 times, most recently
from
9d8818d to
a72b496
Compare
danenbm
approved these changes
Jan 11, 2025
kespinola
force-pushed
the
das-46-show-fungibles-rpc-option
branch
from
a72b496 to
5aaf576
Compare
kespinola
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.