-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MTG-1007] Updated solana version to 2 #85
Open
kstepanovdev
wants to merge
2
commits into
main
Choose a base branch
from
feature/update-solana-version
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstepanovdev
requested review from
StanChe,
n00m4d,
danenbm and
blockiosaurus
December 2, 2024 17:00
StanChe
reviewed
Dec 2, 2024
kstepanovdev
force-pushed
the
feature/update-solana-version
branch
from
December 2, 2024 17:27
e650711
to
5e31e99
Compare
kstepanovdev
changed the title
[MTG-1007] Updated solana version to 2.1.4
[MTG-1007] Updated solana version to 2
Dec 2, 2024
StanChe
previously approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks legit
kstepanovdev
force-pushed
the
feature/update-solana-version
branch
4 times, most recently
from
December 3, 2024 01:54
c7be7fe
to
b273824
Compare
n00m4d
previously approved these changes
Dec 3, 2024
Changed imports respectively; Updated Dockerfile and docs; Changed methods to match the required interface;
kstepanovdev
force-pushed
the
feature/update-solana-version
branch
from
December 3, 2024 12:08
b273824
to
cd2a712
Compare
kstepanovdev
force-pushed
the
feature/update-solana-version
branch
from
December 6, 2024 11:59
494bbee
to
ba1dee8
Compare
StanChe
reviewed
Dec 6, 2024
StanChe
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not following why we use latest as both stable and nightly, otherwise, looks great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for updating is to provide a possibility of running the Solana node with version 2.