Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Following best practices for closing accounts #1187

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Following best practices for closing accounts #1187

merged 3 commits into from
Oct 31, 2024

Conversation

blockiosaurus
Copy link
Contributor

No description provided.

@blockiosaurus blockiosaurus requested a review from a team as a code owner October 28, 2024 15:05
@blockiosaurus blockiosaurus requested review from devonbeard, kstepanovdev and danenbm and removed request for a team October 28, 2024 15:05
danenbm
danenbm previously approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left one comment for potential to improve error handling but not required

core/rust/utils/src/account.rs Outdated Show resolved Hide resolved
@blockiosaurus blockiosaurus merged commit 0ca5009 into master Oct 31, 2024
40 checks passed
@blockiosaurus blockiosaurus deleted the fix/better-account-close branch October 31, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danenbm danenbm danenbm approved these changes

@devonbeard devonbeard Awaiting requested review from devonbeard devonbeard is a code owner automatically assigned from metaplex-foundation/protocol

@kstepanovdev kstepanovdev Awaiting requested review from kstepanovdev kstepanovdev is a code owner automatically assigned from metaplex-foundation/protocol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blockiosaurus @danenbm