V2/recipe #7
Merged
V2/recipe #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1. Wrong escrow seeds on capture_v2 and release_v2 2. Added migration security check of authority 3. Fixed size math on recipe size 4. Path set 0 to reroll
blockiosaurus
merged commit 90d5eae
into
metaplex-foundation:main
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2 mpl-hybrid
a) Creating a recipe account with swap logic
b) Creating a separate escrowV2 account that simply holds/signs for assets
Now multiple recipes can be used on a single escrow.
Now you can have different capture/release fees (tokens and SOL)
Patches multiplying overflow on capture by using a wrapping_mul
Boxes some large accounts
Migration from escrowV1 to escrowV2
Transfers NFTs and tokens from escrowV1 to your escrowV2