Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the inability to descrease in size both the name and URI during escrow_update #8

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

tonyboylehub
Copy link
Contributor

@tonyboylehub tonyboylehub commented Oct 15, 2024

During update_escrow there were missing isize castings causing NumericalOverflow errors when trying to shorten the length of both name and uri of the in the escrow account.

  • Added isize castings.

Also added some update escrow tests that were missing.

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mpl-hybrid-js-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 3:41pm

Copy link
Contributor

@blockiosaurus blockiosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep the checked calls but adding the casting first should fix those.

@tonyboylehub tonyboylehub merged commit 4aa2705 into main Nov 19, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants