Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding denylist tests #113

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding denylist tests #113

wants to merge 2 commits into from

Conversation

blockiosaurus
Copy link
Collaborator

No description provided.

@blockiosaurus blockiosaurus requested a review from febo March 7, 2023 14:44
danenbm
danenbm requested changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, mostly around changing names or comments that are incorrect due to inverting things with the NOT. Otherwise looking good.

program/tests/additional_signer.rs Outdated Show resolved Hide resolved
program/tests/additional_signer.rs Outdated Show resolved Hide resolved
program/tests/additional_signer.rs Outdated Show resolved Hide resolved
program/tests/all.rs Outdated Show resolved Hide resolved
program/tests/all.rs Outdated Show resolved Hide resolved
program/tests/denylist_royalty_enforcement.rs Outdated Show resolved Hide resolved
program/tests/denylist_royalty_enforcement.rs Outdated Show resolved Hide resolved
program/tests/denylist_royalty_enforcement.rs Outdated Show resolved Hide resolved
program/tests/denylist_royalty_enforcement.rs Outdated Show resolved Hide resolved
program/tests/denylist_royalty_enforcement.rs Outdated Show resolved Hide resolved
danenbm
danenbm requested changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good but lastly a couple nits for outdated comments.

program/tests/denylist_royalty_enforcement.rs
process_failing_validate_ix!(&mut context, validate_ix, vec![], Some(ADDITIONAL_COMPUTE))
.await;

// Check that error is what we expect. Program owner was not on the allow list.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: outdated comment

program/tests/denylist_royalty_enforcement.rs
process_failing_validate_ix!(&mut context, validate_ix, vec![], Some(ADDITIONAL_COMPUTE))
.await;

// Check that error is what we expect. Program owner was not on the allow list.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: outdated comment

program/tests/denylist_royalty_enforcement.rs
process_failing_validate_ix!(&mut context, validate_ix, vec![], Some(ADDITIONAL_COMPUTE))
.await;

// Check that error is what we expect. Program owner was not on the allow list.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: outdated comment

program/tests/denylist_royalty_enforcement.rs
.unwrap()
.instruction();

// Fail to validate operation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: outdated comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danenbm danenbm danenbm requested changes

@febo febo Awaiting requested review from febo

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blockiosaurus @danenbm