Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug messages #64

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

febo
Copy link
Contributor

@febo febo commented Feb 29, 2024

This PR removes debug error messages, which might confuse users since they suggest that something went wrong on the IDL generation. These were introduced with the new idl_instruction attribute.

Debug error messages currently being displayed (and removed by this PR):

[resolve_rust_ty] Ident(Metadata): TypeKind::Value(Value::Custom("Metadata"))
[resolve_rust_ty] Ident(DelegateInput): TypeKind::Value(Value::Custom("DelegateInput"))
[resolve_rust_ty] Ident(Extension): TypeKind::Value(Value::Custom("Extension"))
[resolve_rust_ty] Ident(DelegateInput): TypeKind::Value(Value::Custom("DelegateInput"))
[resolve_rust_ty] Ident(UpdateInput): TypeKind::Value(Value::Custom("UpdateInput"))
[resolve_rust_ty] Ident(Data): TypeKind::Value(Value::Custom("Data"))
no #[idl_instruction] attributes found
no #[idl_instruction] attributes found
no #[idl_instruction] attributes found
no #[idl_instruction] attributes found
no #[idl_instruction] attributes found
no #[idl_instruction] attributes found
no #[idl_instruction] attributes found
no #[idl_instruction] attributes found
no #[idl_instruction] attributes found
no #[idl_instruction] attributes found
no #[idl_instruction] attributes found
no #[idl_instruction] attributes found
no #[idl_instruction] attributes found
no #[idl_instruction] attributes found
no #[idl_instruction] attributes found
[resolve_rust_ty] Ident(String): TypeKind::Value(Value::String)
[resolve_rust_ty] Ident(Standard): TypeKind::Value(Value::Custom("Standard"))
[resolve_rust_ty] Ident(bool): TypeKind::Primitive(Primitive::Bool)
[resolve_rust_ty] Ident(ExtensionType): TypeKind::Value(Value::Custom("ExtensionType"))
[resolve_rust_ty] Ident(u32): TypeKind::Primitive(Primitive::U32)
[resolve_rust_ty] Ident(u8): TypeKind::Primitive(Primitive::U8)
[resolve_rust_ty] Ident(Vec): TypeKind::Composite(Composite::Vec, [RustType { ident: Ident(u8), kind: TypeKind::Primitive(Primitive::U8), reference: ParsedReference::Owned, context: CollectionItem }])
[resolve_rust_ty] Ident(Option): TypeKind::Composite(Composite::Option, [RustType { ident: Ident(Vec), kind: TypeKind::Composite(Composite::Vec, [RustType { ident: Ident(u8), kind: TypeKind::Primitive(Primitive::U8), reference: ParsedReference::Own

It also fixes clippy warnings.

Copy link

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend! 🫶

@blockiosaurus blockiosaurus merged commit 68d3193 into metaplex-foundation:master Feb 29, 2024
5 checks passed
@febo febo deleted the febo/remove-error-log branch February 29, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants