Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nft.storage version to fix type URLSearchParams error #112

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

KishiTheMechanic
Copy link
Contributor

Somehow we've got the error when using upload method.
TypeError: Value of "this" must be of type URLSearchParams

So I changed to use nft.storage directly and version 7.1.1 worked.

But same code didn't work with 6.4.1 (with this package.) (It's helped by rikisann on Discord.)

So I think this updating fixes the error.

We hope we can use the umi uploader because it's so helpful for us.

Thank you for the great framework team!

Have a great day☀

Best regards,
Shota Kishi

Copy link

changeset-bot bot commented Jan 16, 2024

🦋 Changeset detected

Latest commit: 6652f1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@metaplex-foundation/umi-uploader-nft-storage Patch
@metaplex-foundation/umi Patch
@metaplex-foundation/umi-bundle-defaults Patch
@metaplex-foundation/umi-bundle-tests Patch
@metaplex-foundation/umi-downloader-http Patch
@metaplex-foundation/umi-eddsa-web3js Patch
@metaplex-foundation/umi-http-fetch Patch
@metaplex-foundation/umi-program-repository Patch
@metaplex-foundation/umi-rpc-chunk-get-accounts Patch
@metaplex-foundation/umi-rpc-web3js Patch
@metaplex-foundation/umi-serializer-beet Patch
@metaplex-foundation/umi-serializer-data-view Patch
@metaplex-foundation/umi-signer-derived Patch
@metaplex-foundation/umi-signer-wallet-adapters Patch
@metaplex-foundation/umi-storage-mock Patch
@metaplex-foundation/umi-transaction-factory-web3js Patch
@metaplex-foundation/umi-uploader-aws Patch
@metaplex-foundation/umi-uploader-bundlr Patch
@metaplex-foundation/umi-uploader-irys Patch
@metaplex-foundation/umi-web3js-adapters Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lorisleiva
Copy link
Collaborator

Hi there, can you confirm there aren't any significant breaking changes from 6.4 to 7.1?

@KishiTheMechanic
Copy link
Contributor Author

KishiTheMechanic commented Jan 16, 2024

Thank you for your reviewing!🙏

There is only one little breaking.

nft.storage: v7.0.0
7.0.0 (2022-07-29)
⚠ BREAKING CHANGES
rate-limit ucan auth requests (#2097)
Features
rate-limit ucan auth requests (#2097) (1e43a31)

nftstorage/nft.storage@nft.storage-v6.4.1...nft.storage-v7.0.0

nftstorage/nft.storage#2097

I don't think it's a huge breaking change though please check them.

Thank you so much!

Best regards,

@lorisleiva
Copy link
Collaborator

Cool, I'm happy with that then. Could you run pnpm install locally so it also updates the lock file?

@KishiTheMechanic
Copy link
Contributor Author

Thank you🙌

I did pnpm install👍

@lorisleiva lorisleiva merged commit 7c03bd1 into metaplex-foundation:main Jan 17, 2024
6 checks passed
@lorisleiva
Copy link
Collaborator

Thank you for your contribution! 🍺

@github-actions github-actions bot mentioned this pull request Jan 17, 2024
@KishiTheMechanic
Copy link
Contributor Author

Thank you for your reviewing and merging🙌🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants