-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nft.storage version to fix type URLSearchParams error #112
Conversation
🦋 Changeset detectedLatest commit: 6652f1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi there, can you confirm there aren't any significant breaking changes from 6.4 to 7.1? |
Thank you for your reviewing!🙏 There is only one little breaking.
nftstorage/nft.storage@nft.storage-v6.4.1...nft.storage-v7.0.0 I don't think it's a huge breaking change though please check them. Thank you so much! Best regards, |
Cool, I'm happy with that then. Could you run |
Thank you🙌 I did |
Thank you for your contribution! 🍺 |
Thank you for your reviewing and merging🙌🍻 |
Somehow we've got the error when using upload method.
TypeError: Value of "this" must be of type URLSearchParams
So I changed to use nft.storage directly and version 7.1.1 worked.
But same code didn't work with 6.4.1 (with this package.) (It's helped by rikisann on Discord.)
So I think this updating fixes the error.
We hope we can use the umi uploader because it's so helpful for us.
Thank you for the great framework team!
Have a great day☀
Best regards,
Shota Kishi