-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition from @bundlr-network/client
to @irys/sdk
#91
Transition from @bundlr-network/client
to @irys/sdk
#91
Conversation
🦋 Changeset detectedLatest commit: 4f5653f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@bundlr-network/client
to @irys/sdk
A known fix to this issue in the meantime is to update/refresh lockfiles - I released a backported version with a fixed git repo URL, and the lockfile refresh seems to have worked for all the users having issues thusfar. |
Hi there. This PR is a real help, thanks for that! The only thing I would say is it's probably best to add another package and marking the old one has deprecated instead of replacing it. We'll also need a changeset so it can tricker a publish. I'd say a patch update would be enough since we'd be adding a new plugin and therefore not introducing any breaking change. |
hey @lorisleiva , apologies for the long stint of inactivity. |
I would just replace it on the I would also add a new line of the implementation table (instead of replacing it) and mark the old line as deprecated by just suffixing it's name by |
As far as I could tell, |
Ah yeah sorry I was being silly. The last thing I noticed before merging this is that the CHANGELOG file was copy/pasted from the Bundlr package when I think it should be removed as this package will have it's own history starting from now. |
Changelog has been removed |
@lorisleiva is there anything else I need to do? |
Ugh linting again here. Could you do |
@lorisleiva done |
43a25a9
to
4f5653f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Note: This PR (a spiritual copy of this PR) seeks to accomplish the same goals for the same reasons.
Context: Bundlr rebranded as Irys earlier today, and the GH org rename caused issues with users due to the AVSC git dependency the old version of the js-client being used.
To fix this, this PR transitions from a deprecated Bundlr js sdk version to the latest Irys SDK, and includes all relevant changes/renaming, including README & test changes.
Notes: