fix: test endAfterSubtests must not fail if test is done

metarhia · Mar 9, 2022 · 4261d8a · 4261d8a
1 parent 631bb53
commit 4261d8a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,11 @@ and this project adheres to
 
 ## [Unreleased][unreleased]
 
+### Fixed
+
+- bug where `test.endAfterSubtests()` would cause an error if the test was
+  finished before `endAfterSubtests` got a chance to process its checks.
+
 ## [0.8.1][] - 2022-03-06
 
 ### Added

diff --git a/lib/imperative-test.js b/lib/imperative-test.js
@@ -174,7 +174,7 @@ class ImperativeTest extends Test {
   endAfterSubtests() {
     this.waitingSubtests = true;
     process.nextTick(() => {
-      if (!this._hasPendingSubtests()) this.end();
+      if (!this._hasPendingSubtests() && !this.done) this.end();
     });
   }
 

diff --git a/test/imperative.js b/test/imperative.js
@@ -91,6 +91,12 @@ metatests.test('nested test', t1 => {
   });
 });
 
+metatests.test('nested test that ends before endAfterSubtests', t1 => {
+  t1.strictSame(123, 123);
+  t1.endAfterSubtests();
+  t1.end();
+});
+
 metatests.testAsync('nested test that ends after each subtest', test => {
   let i = 0;
   test.strictSame(++i, 1);