fix(typegraph): prisma where fields types #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThe changes introduce significant updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant WG as Where Generator
participant SF as StringFilter
WG->>SF: Instantiate StringFilter with prop.prop_type
SF->>SF: Call generate() using the format
SF->>SF: Compose name() using format value
SF-->>WG: Return generated filter
sequenceDiagram
participant Test as Test Suite
participant Prisma as Prisma Engine
participant DB as Database
Test->>Prisma: Initialize engine with connection string
Test->>DB: Drop existing schemas and reapply migrations
Test->>Prisma: Send findRecord query with invalid UUID
Prisma->>DB: Validate query input
DB-->>Prisma: Return error for invalid UUID format
Prisma-->>Test: Return 400 error with detailed message
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
luckasRanarison
force-pushed
the
met-751-fix-where-string-param
branch
from
0f71084 to
87e2527
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
tests/runtimes/prisma/invalid_query_test.ts (2)
24-26: Fix typo in error message.The error message contains a typo: "statisfy" should be "satisfy".
- "string does not statisfy the required format 'uuid'", + "string does not satisfy the required format 'uuid'",
15-28: Consider adding more test cases.The test could be expanded to cover more edge cases for string validation:
- Empty string
- Special characters
- Different UUID formats
await t.should("validate string types in where", async () => { + // Test empty string + await gql` + query { + findRecord(where: { id: "" }) { + id + } + } + ` + .expectStatus(400) + .expectErrorContains( + "string does not satisfy the required format 'uuid'", + ) + .on(e); + + // Test special characters + await gql` + query { + findRecord(where: { id: "!@#$%^&*()" }) { + id + } + } + ` + .expectStatus(400) + .expectErrorContains( + "string does not satisfy the required format 'uuid'", + ) + .on(e); + await gql` query { findRecord(where: { id: "invaliduuid" }) { id } } ` .expectStatus(400) .expectErrorContains( "string does not satisfy the required format 'uuid'", ) .on(e); });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (27)
src/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many Post out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many Record inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many Record out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many User out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique Post out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique Record inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique Record out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique User out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by Post out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by Record inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by Record out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by User out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_many Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_many Record inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_many User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_one Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_one Record inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_one User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__where___test__where Post.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__where___test__where Record.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__where___test__where User.snapis excluded by!**/*.snap
📒 Files selected for processing (4)
src/typegate/src/engine/typecheck/input.ts(3 hunks)src/typegraph/core/src/runtimes/prisma/type_generation/filters.rs(2 hunks)src/typegraph/core/src/runtimes/prisma/type_generation/where_.rs(2 hunks)tests/runtimes/prisma/invalid_query_test.ts(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- src/typegate/src/engine/typecheck/input.ts
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: bulid-docker (linux/arm64, custom-arm)
- GitHub Check: test-full
- GitHub Check: lint-compat (macos-14, aarch64-apple-darwin, false)
- GitHub Check: bulid-docker (linux/amd64, custom-ubuntu-large)
- GitHub Check: lint-compat (macos-13, x86_64-apple-darwin, false)
- GitHub Check: pre-commit
🔇 Additional comments (4)
src/typegraph/core/src/runtimes/prisma/type_generation/where_.rs (1)
89-103: LGTM! Improved type safety with explicit type_id.The changes enhance type safety by explicitly passing
type_idtoStringFilter. This ensures proper type validation for string fields.src/typegraph/core/src/runtimes/prisma/type_generation/filters.rs (3)
115-117: LGTM! Enhanced StringFilter with type_id.The addition of
type_idfield makes theStringFiltermore flexible by allowing external type specification.
121-122: LGTM! Proper type_id usage.The code correctly uses the struct's
type_idfield for type generation.
146-146: LGTM! Unique filter names.The name method now generates unique filter names by incorporating the
type_id, preventing potential naming conflicts.
luckasRanarison
commented
Feb 5, 2025
src/typegraph/core/src/runtimes/prisma/type_generation/filters.rs
Outdated
Show resolved
Hide resolved
|
Also do you guys think we should reuse other scalar types? |
Natoandro
previously approved these changes
Feb 5, 2025
luckasRanarison
changed the title
luckasRanarison
changed the title
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/typegraph/core/src/runtimes/prisma/type_generation/filters.rs (1)
153-154: Consider tracking the full text search feature.The TODO comment indicates a missing feature for full text search that depends on a preview feature.
Would you like me to create an issue to track the implementation of the full text search feature?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (35)
src/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__query_where_expr__tests__Post__QueryWhereExpr.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__query_where_expr__tests__User__QueryWhereExpr.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__create_many Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__create_many Post out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__create_many User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__create_many User out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__create_one Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__create_one User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many Post out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many Record inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many Record out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many User out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique Post out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique Record inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique Record out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique User out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by Post out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by Record inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by Record out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by User out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_many Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_many Record inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_many User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_one Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_one Record inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_one User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__where___test__where Post.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__where___test__where Record.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__where___test__where User.snapis excluded by!**/*.snap
📒 Files selected for processing (2)
src/typegraph/core/src/runtimes/prisma/type_generation/filters.rs(5 hunks)src/typegraph/core/src/runtimes/prisma/type_generation/where_.rs(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/typegraph/core/src/runtimes/prisma/type_generation/where_.rs
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: lint-compat (macos-14, aarch64-apple-darwin, false)
- GitHub Check: lint-compat (macos-13, x86_64-apple-darwin, false)
- GitHub Check: test-full
- GitHub Check: pre-commit
🔇 Additional comments (3)
src/typegraph/core/src/runtimes/prisma/type_generation/filters.rs (3)
68-77: LGTM! Well-structured constructor.The
from_typeconstructor provides a clean way to create filters from number types, with clear type mapping.
133-135: LGTM! Clean struct definition.The struct is well-focused with a single responsibility.
355-358: LGTM! Proper use of new constructor.The function correctly uses the new
from_typeconstructor and maintains proper error handling.
src/typegraph/core/src/runtimes/prisma/type_generation/filters.rs
Outdated
Show resolved
Hide resolved
|
Oh, looking at the diff I think I did something wrong |
luckasRanarison
force-pushed
the
met-751-fix-where-string-param
branch
from
2f1186d to
3e1b0ee
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/typegraph/schema/src/runtimes/prisma.rs (1)
77-79: Add tests for string type representations.Since
StringTypeis used inScalarType::Stringand its string representation is crucial for schema generation, consider adding tests to verify the correct string output for each variant.Would you like me to help generate test cases for the
Displayimplementation? Here's an example of what could be added:#[cfg(test)] mod tests { use super::*; #[test] fn test_string_type_display() { assert_eq!(StringType::Plain.to_string(), "string"); assert_eq!(StringType::Uuid.to_string(), "uuid"); assert_eq!(StringType::DateTime.to_string(), "date-time"); } }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (27)
src/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many Post out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many Record inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many Record out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_many User out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique Post out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique Record inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique Record out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__find_unique User out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by Post out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by Record inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by Record out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__group_by User out.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_many Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_many Record inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_many User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_one Post inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_one Record inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__test__update_one User inp.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__where___test__where Post.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__where___test__where Record.snapis excluded by!**/*.snapsrc/typegraph/core/src/runtimes/prisma/type_generation/snapshots/typegraph_core__runtimes__prisma__type_generation__where___test__where User.snapis excluded by!**/*.snap
📒 Files selected for processing (3)
src/typegraph/core/src/runtimes/prisma/type_generation/filters.rs(3 hunks)src/typegraph/core/src/runtimes/prisma/type_generation/where_.rs(2 hunks)src/typegraph/schema/src/runtimes/prisma.rs(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- src/typegraph/core/src/runtimes/prisma/type_generation/where_.rs
- src/typegraph/core/src/runtimes/prisma/type_generation/filters.rs
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: lint-compat (macos-14, aarch64-apple-darwin, false)
- GitHub Check: lint-compat (macos-13, x86_64-apple-darwin, false)
- GitHub Check: test-full
- GitHub Check: pre-commit
🔇 Additional comments (1)
src/typegraph/schema/src/runtimes/prisma.rs (1)
60-68: Add documentation for the Display implementation.The implementation looks good and follows best practices. Consider adding documentation to explain the purpose and usage of these string representations.
Add documentation above the implementation:
+/// Implements Display for StringType to provide string representations +/// that align with Prisma's type format specifications. +/// - Plain -> "string" +/// - Uuid -> "uuid" +/// - DateTime -> "date-time" impl std::fmt::Display for StringType {Let's verify that these string representations align with Prisma's expectations:
Natoandro
approved these changes
Feb 11, 2025
Yohe-Am
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration notes
Summary by CodeRabbit
New Features
formatfield in theStringFilter, allowing for customized string type definitions.StringTypevariants, improving clarity in type handling.Tests