Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing optional pyaro dep #53

Closed
wants to merge 1 commit into from

Conversation

magnusuMET
Copy link
Collaborator

New versions of pyaro requires additional features which will be necessary when implementing filtering in the readers

@magnusuMET magnusuMET requested a review from heikoklein October 30, 2024 08:58
@heikoklein
Copy link
Member

Sorry, this was a bug in pyaro 0.12 and has been fixed in 0.13. Don't use the optional requirements, rather bump the version.

@@ -22,7 +22,7 @@ classifiers = [
]
requires-python = ">=3.9"
dependencies = [
"pyaro >=0.0.6",
"pyaro[optional] >=0.0.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use 0.0.13, as soon as it is released: metno/pyaro#55

@magnusuMET
Copy link
Collaborator Author

We should fix the pyaro version required the setup.cfg. I've opened metno/pyaro#56 to allow for non-breaking fixes

@magnusuMET magnusuMET closed this Oct 30, 2024
@magnusuMET magnusuMET deleted the bugfix/missing_deps branch October 30, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants