Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes associated with the lard integration #94

Merged
merged 8 commits into from
Jan 23, 2025
Merged

Fixes associated with the lard integration #94

merged 8 commits into from
Jan 23, 2025

Conversation

intarga
Copy link
Member

@intarga intarga commented Dec 11, 2024 •
edited
Loading

@intarga intarga added the bug Something isn't working label Dec 11, 2024
@intarga intarga mentioned this pull request Jan 17, 2025
Merged
7 tasks
@intarga intarga marked this pull request as ready for review January 17, 2025 15:15
@intarga intarga requested a review from Lun4m January 17, 2025 15:16
Lun4m
Lun4m previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@Lun4m Lun4m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 👍 Are we postponing the Conf structs docs in case we decide we want to move olympian here?

@intarga
Copy link
Member Author

intarga commented Jan 20, 2025

Looks fine 👍 Are we postponing the Conf structs docs in case we decide we want to move olympian here?

No, I just figured they would be a repetition of the olympian docs, and it's better to refer to those. We probably should include docs when there are confs that don't directly map to olympian parameters, like climate_range_check and compare_with_model

@intarga intarga requested a review from Lun4m January 22, 2025 15:29
@intarga
Copy link
Member Author

intarga commented Jan 22, 2025

@Lun4m I've added doc links to olympian on the confs that directly map to olympian checks, and TODOs for the ones that don't but aren't concretely implemented yet

@intarga intarga merged commit e6d0d22 into trunk Jan 23, 2025
1 check passed
@intarga intarga deleted the lard_fixes branch January 23, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lun4m Lun4m Lun4m approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@intarga @Lun4m