feat: Syslog wrapper #201
Open
feat: Syslog wrapper #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmaxde
force-pushed
the
feat_syslog
branch
5 times, most recently
from
ccc4a3b
to
5ce43fe
Compare
bmario
requested changes
Nov 5, 2024
| return syslog_header + message | ||
|
|
||
|
|
||
| def get_syslog_handler(address: str) -> SysLogHandler: |
There was a problem hiding this comment.
Suggested change
| def get_syslog_handler(address: str) -> SysLogHandler: | |
| def get_syslog_handler(address: str | None) -> SysLogHandler: |
metricq/cli/wrapper.py
Outdated
| if value is not None: | ||
| logger = get_logger() | ||
|
|
||
| program_name: str = "metricq_program" |
There was a problem hiding this comment.
metricq_program is worse than the actual default, which is the process name.
metricq/cli/wrapper.py
Outdated
|
|
||
| return option( | ||
| "--syslog", | ||
| help="Enable syslog logging by specifying the syslog path or URL for the logger.", |
There was a problem hiding this comment.
The intended format is not a URL. A URL contains a scheme, but a hostname-port tuple does not. The path is a UNIX domain socket.
devmaxde
force-pushed
the
feat_syslog
branch
2 times, most recently
from
4a81244
to
8168afe
Compare
devmaxde
force-pushed
the
feat_syslog
branch
from
8168afe
to
7eb526a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing the @metricq_syslog() wrapper for click commands, that configures the logger to sent to a Syslog Location (local or remote)