Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replaces errors.leasingAgentAddress with errors.listingsLeasingA… #1057

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adriencyberspace
Copy link
Collaborator

@adriencyberspace adriencyberspace commented Jan 22, 2025

…gentAddress

This PR addresses bloom-housing#4516

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This PR fixes the form validation for partial address in the Leasing Agent Address section of the partners listing form. Before, the error was throwing but there was no visible indication for the user. Now when a user enters an impartial address, the correct fields are highlighted and they get the appropriate error message below those fields.

How Can This Be Tested/Reviewed?

Screenshot 2025-01-15 at 2 49 23 PM

Fill out a street address in the partners listing form without a city, state and/or zip and find that the correct errors are thrown and visible.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@adriencyberspace adriencyberspace added ready to merge Should be applied when a PR has been reviewed and approved 1 review needed and removed ready to merge Should be applied when a PR has been reviewed and approved labels Jan 22, 2025
Copy link
Collaborator

@mcgarrye mcgarrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcgarrye mcgarrye added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants