Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: refactor and extend zip code (#4588) #1062

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

mcgarrye
Copy link
Collaborator

This PR addresses #(4370)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Generalized zip exporting code to allow for applications export to be zipped.

How Can This Be Tested/Reviewed?

With a listing that has applications, go to the applications tab.
Export the applications.
Confirm export was a zip file.
Open zip file, confirm csv is created.
Open CSV file and check contents.

Edit listing to be a lottery.
Run lottery.
Export lottery.
Confirm export was a zip file.
Open zip file, confirm XSLX is created.
Open XSLX file and check contents.

Bring down the app.
Change APPLICATION_EXPORT_AS_SPREADSHEET to TRUE in the sites/partners/.env file.
With a listing that has applications, go to the applications tab.
Export the applications.
Confirm export was a zip file.
Open zip file, confirm XSLX is created.
Open XSLX file and check contents.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

* chore: refactor and extend zip code

4370

* chore: cleanup imports

4370

* chore: adjust logic to reduce calls in controllers

4370

* chore: linting

4370
@mcgarrye mcgarrye added 2 reviews needed release A PR that is pulling over a commit(s) from core labels Jan 24, 2025
api/src/services/application-exporter.service.ts Dismissed Show dismissed Hide dismissed
api/src/services/application-exporter.service.ts Dismissed Show dismissed Hide dismissed
api/src/utilities/zip-export.ts Dismissed Show dismissed Hide dismissed
api/src/utilities/zip-export.ts Dismissed Show dismissed Hide dismissed
Copy link
Collaborator

@ColinBuyck ColinBuyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚯

@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Feb 4, 2025
@mcgarrye mcgarrye merged commit 6520adf into main Feb 4, 2025
16 checks passed
@mcgarrye mcgarrye deleted the release/zip-app-csv branch February 4, 2025 21:30
@mcgarrye mcgarrye removed the ready to merge Should be applied when a PR has been reviewed and approved label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release A PR that is pulling over a commit(s) from core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants