Skip to content

Commit

Permalink
Merge pull request #37 from metrumresearchgroup/release/3.5.0
Browse files Browse the repository at this point in the history
Release 3.5.0
  • Loading branch information
andersone1 authored Sep 26, 2023
2 parents 5328ffb + 95d247e commit 5482740
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: review
Title: Manage Review Logs
Version: 3.4.0.8005
Version: 3.5.0
Authors@R:
c(
person(given = "Eric", family = "Anderson", email = "[email protected]", role = c("aut")),
Expand Down
8 changes: 8 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# review 3.5.0

## New features and changes

- `dirSummary` added to provide QC status of all scripts/models in a given directory. (#29, #30)

- `renderQCSummary` added to create a pdf summary of the QC status of scripts in a given directory. (#29, #31, #32, #33, #35, #36)

# review 3.4.0

## New features and changes
Expand Down
2 changes: 1 addition & 1 deletion inst/templates/QCSummary.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
params:
dirSummaryRes: "`r list()`"
title: "QC Summary"
subtitle: "`r params$dirSummaryRes$project`"
subtitle: "`r paste0(params$dirSummaryRes$project, ' (/', params$dirSummaryRes$directory, ')')`"
date: "`r format(Sys.time(), '%d %B, %Y %H:%M %Z')`"
output:
pdf_document:
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/test-renderQCSummary.R
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ logAccept(file = "file3.R")
add_file("file.R", "something-new")
add_commit("second")

if (interactive()) {
if (Sys.getenv("METWORX_VERSION") != "") {
test_that("renderQCSummary works with valid directory", {

expect_silent({
Expand All @@ -36,7 +36,7 @@ if (interactive()) {
expect_true(file.exists(file.path(logRoot(), paste0("qc-summary-", Sys.Date(), ".pdf"))))

})

test_that("renderQCSummary doesn't save file if directory not given", {

temp_dir <- tempdir()
Expand Down

0 comments on commit 5482740

Please sign in to comment.