Escape HTML chars (open-eid#1257)

IB-8019 Signed-off-by: Raul Metsma <[email protected]>
metsma · May 6, 2024 · 1e9d99e · 1e9d99e
1 parent a72b79e
commit 1e9d99e
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/client/dialogs/SignatureDialog.cpp b/client/dialogs/SignatureDialog.cpp
@@ -111,7 +111,7 @@ SignatureDialog::SignatureDialog(const DigiDocSignature &signature, QWidget *par
 		d->showErrors->show();
 
 	QString name = !c.isNull() ? c.toString(c.showCN() ? QStringLiteral("CN serialNumber") : QStringLiteral("GN SN serialNumber")) : s.signedBy();
-	d->title->setText(QStringLiteral("%1 | %2%3</font>").arg(name, style, status));
+	d->title->setText(QStringLiteral("%1 | %2%3</font>").arg(name.toHtmlEscaped(), style, status));
 	d->close->setFont(Styles::font(Styles::Condensed, 14));
 	connect(d->close, &QPushButton::clicked, this, &SignatureDialog::accept);
 

diff --git a/client/dialogs/SignatureDialog.ui b/client/dialogs/SignatureDialog.ui
@@ -202,6 +202,9 @@ QScrollBar::sub-line:vertical {
              <height>31</height>
             </size>
            </property>
+           <property name="textFormat">
+            <enum>Qt::PlainText</enum>
+           </property>
            <property name="textInteractionFlags">
             <set>Qt::TextSelectableByKeyboard|Qt::TextSelectableByMouse</set>
            </property>
@@ -231,6 +234,9 @@ QScrollBar::sub-line:vertical {
              <height>31</height>
             </size>
            </property>
+           <property name="textFormat">
+            <enum>Qt::PlainText</enum>
+           </property>
            <property name="textInteractionFlags">
             <set>Qt::TextSelectableByKeyboard|Qt::TextSelectableByMouse</set>
            </property>
@@ -260,6 +266,9 @@ QScrollBar::sub-line:vertical {
              <height>31</height>
             </size>
            </property>
+           <property name="textFormat">
+            <enum>Qt::PlainText</enum>
+           </property>
            <property name="textInteractionFlags">
             <set>Qt::TextSelectableByKeyboard|Qt::TextSelectableByMouse</set>
            </property>
@@ -289,6 +298,9 @@ QScrollBar::sub-line:vertical {
              <height>31</height>
             </size>
            </property>
+           <property name="textFormat">
+            <enum>Qt::PlainText</enum>
+           </property>
            <property name="wordWrap">
             <bool>true</bool>
            </property>
@@ -327,6 +339,9 @@ QScrollBar::sub-line:vertical {
              <height>300</height>
             </size>
            </property>
+           <property name="textFormat">
+            <enum>Qt::PlainText</enum>
+           </property>
            <property name="wordWrap">
             <bool>true</bool>
            </property>

diff --git a/client/widgets/AddressItem.cpp b/client/widgets/AddressItem.cpp
@@ -65,7 +65,7 @@ AddressItem::AddressItem(CKey k, QWidget *parent, bool showIcon)
 			ui->key.cert.subjectInfo("GN").join(' ') + " " + ui->key.cert.subjectInfo("SN").join(' ') :
 			ui->key.cert.subjectInfo("CN").join(' ')).toHtmlEscaped();
 	if(ui->label.isEmpty())
-		ui->label = ui->key.recipient;
+		ui->label = ui->key.recipient.toHtmlEscaped();
 	setIdType();
 	showButton(AddressItem::Remove);
 }