Remove Test signature leftovers (open-eid#1079)

IB-7425 Signed-off-by: Raul Metsma <[email protected]>
metsma · Jul 25, 2022 · 9517165 · 9517165
1 parent dd4ff8c
commit 9517165
Show file tree

Hide file tree

Showing 8 changed files with 3 additions and 64 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -115,7 +115,9 @@ jobs:
         path: libdigidocpp-pkg
         repo: open-eid/libdigidocpp
     - name: Install artifact
-      run: dnf install -y ./libdigidocpp-pkg/*$(lsb_release -rs)*.rpm
+      run: |
+        . /etc/os-release
+        dnf install -y ./libdigidocpp-pkg/*fc${VERSION_ID}*.rpm
     - name: Build
       run: |
         cmake -DCMAKE_INSTALL_PREFIX=/usr -B build -S .

diff --git a/client/DigiDoc.h b/client/DigiDoc.h
@@ -38,7 +38,6 @@ class DigiDocSignature
 		Valid,
 		Warning,
 		NonQSCD,
-		Test,
 		Invalid,
 		Unknown
 	};

diff --git a/client/PrintSheet.cpp b/client/PrintSheet.cpp
@@ -140,7 +140,6 @@ PrintSheet::PrintSheet( DigiDoc *doc, QPrinter *printer )
 		case DigiDocSignature::Valid: valid = tr("SIGNATURE IS VALID"); break;
 		case DigiDocSignature::Warning:valid = QStringLiteral("%1 (%2)").arg(tr("SIGNATURE IS VALID"), tr("NB! WARNINGS")); break;
 		case DigiDocSignature::NonQSCD:valid = QStringLiteral("%1 (%2)").arg(tr("SIGNATURE IS VALID"), tr("NB! RESTRICTIONS")); break;
-		case DigiDocSignature::Test: valid = QStringLiteral("%1 (%2)").arg(tr("SIGNATURE IS VALID"), tr("NB! TEST SIGNATURE")); break;
 		case DigiDocSignature::Invalid: valid = tr("SIGNATURE IS NOT VALID") ; break;
 		case DigiDocSignature::Unknown: valid = tr("UNKNOWN"); break;
 		}

diff --git a/client/dialogs/SignatureDialog.cpp b/client/dialogs/SignatureDialog.cpp
@@ -81,16 +81,6 @@ SignatureDialog::SignatureDialog(const DigiDocSignature &signature, QWidget *par
 			"This e-Signature is not equivalent with handwritten signature and therefore "
 			"can be used only in transactions where Qualified e-Signature is not required.") );
 		break;
-	case DigiDocSignature::Test:
-		status += QStringLiteral("%1 (%2)").arg(isValid(isTS), tr("Test signature"));
-		if( !s.lastError().isEmpty() )
-			d->error->setPlainText( s.lastError() );
-		d->info->setText( tr(
-			"Test signature is signed with test certificates that are similar to the "
-			"certificates of real tokens, but digital signatures with legal force cannot "
-			"be given with them as there is no actual owner of the card. "
-			"<a href='https://www.id.ee/en/article/verifying-signatures-given-with-test-certificates-in-the-digidoc4-client/'>Additional information</a>.") );
-		break;
 	case DigiDocSignature::Invalid:
 		style = QStringLiteral("<font color=\"red\">");
 		status += isTS ? tr("is not valid", "Timestamp") :  tr("is not valid", "Signature");

diff --git a/client/translations/en.ts b/client/translations/en.ts
@@ -2256,10 +2256,6 @@ and enter Smart-ID PIN2-code.</translation>
         <source>AUTHORITY KEY IDENTIFIER</source>
         <translation>AUTHORITY KEY IDENTIFIER</translation>
     </message>
-    <message>
-        <source>NB! TEST SIGNATURE</source>
-        <translation>NB! TEST SIGNATURE</translation>
-    </message>
     <message>
         <source>NB! WARNINGS</source>
         <translation>NB! WARNINGS</translation>
@@ -2820,18 +2816,10 @@ Additional licenses and components</translation>
         <source>This e-Signature is not equivalent with handwritten signature and therefore can be used only in transactions where Qualified e-Signature is not required.</source>
         <translation>This e-Signature is not equivalent with handwritten signature and therefore can be used only in transactions where Qualified e-Signature is not required.</translation>
     </message>
-    <message>
-        <source>Test signature</source>
-        <translation>Test signature</translation>
-    </message>
     <message>
         <source>Unknown error</source>
         <translation>Unknown error</translation>
     </message>
-    <message>
-        <source>Test signature is signed with test certificates that are similar to the certificates of real tokens, but digital signatures with legal force cannot be given with them as there is no actual owner of the card. &lt;a href=&apos;https://www.id.ee/en/article/verifying-signatures-given-with-test-certificates-in-the-digidoc4-client/&apos;&gt;Additional information&lt;/a&gt;.</source>
-        <translation>Test signature is signed with test certificates that are similar to the certificates of real tokens, but digital signatures with legal force cannot be given with them as there is no actual owner of the card. &lt;a href=&apos;https://www.id.ee/en/article/verifying-signatures-given-with-test-certificates-in-the-digidoc4-client/&apos;&gt;Additional information&lt;/a&gt;.</translation>
-    </message>
     <message>
         <source>This is an invalid signature or malformed digitally signed file. The signature is not valid.</source>
         <translation>This is an invalid signature or malformed digitally signed file. The signature is not valid.</translation>
@@ -2998,10 +2986,6 @@ Additional licenses and components</translation>
         <source>Restrictions</source>
         <translation>Restrictions</translation>
     </message>
-    <message>
-        <source>Test signature</source>
-        <translation>Test signature</translation>
-    </message>
     <message>
         <source>Signed on</source>
         <translation>Signed on</translation>

diff --git a/client/translations/et.ts b/client/translations/et.ts
@@ -2256,10 +2256,6 @@ ja sisesta nutiseadmes Smart-ID PIN2-kood.</translation>
         <source>AUTHORITY KEY IDENTIFIER</source>
         <translation>VÄLJAANDJA VÕTME IDENTIFIKAATOR</translation>
     </message>
-    <message>
-        <source>NB! TEST SIGNATURE</source>
-        <translation>NB! TESTALLKIRI</translation>
-    </message>
     <message>
         <source>NB! WARNINGS</source>
         <translation>NB! HOIATUSEGA</translation>
@@ -2820,18 +2816,10 @@ Täiendavad litsentsid ja komponendid</translation>
         <source>This e-Signature is not equivalent with handwritten signature and therefore can be used only in transactions where Qualified e-Signature is not required.</source>
         <translation>See e-allkiri ei ole käsitsi kirjutatud allkirjadega samaväärne ja seetõttu saab seda kasutada ainult tehingute puhul, kus kvalifitseeritud e-allkiri pole kohustuslik.</translation>
     </message>
-    <message>
-        <source>Test signature</source>
-        <translation>Testallkiri</translation>
-    </message>
     <message>
         <source>Unknown error</source>
         <translation>Tundmatu viga</translation>
     </message>
-    <message>
-        <source>Test signature is signed with test certificates that are similar to the certificates of real tokens, but digital signatures with legal force cannot be given with them as there is no actual owner of the card. &lt;a href=&apos;https://www.id.ee/en/article/verifying-signatures-given-with-test-certificates-in-the-digidoc4-client/&apos;&gt;Additional information&lt;/a&gt;.</source>
-        <translation>Testallkiri on allkirjastatud testsertifikaadiga, mis sarnaneb päris sertifikaadiga, kuid sellega ei saa anda õigusjõuga digitaalallkirju, sest kaardi omanikku tegelikkuses ei eksisteeri. &lt;a href=&apos;https://www.id.ee/artikkel/testsertifikaatidega-antud-allkirjade-kontrollimine-digidoc4-kliendis/&apos;&gt;Täiendav info&lt;/a&gt;.</translation>
-    </message>
     <message>
         <source>This is an invalid signature or malformed digitally signed file. The signature is not valid.</source>
         <translation>See allkiri või allkirjastatud fail on vigane. Allkiri ei ole kehtiv.</translation>
@@ -2998,10 +2986,6 @@ Täiendavad litsentsid ja komponendid</translation>
         <source>Restrictions</source>
         <translation>Piirangud</translation>
     </message>
-    <message>
-        <source>Test signature</source>
-        <translation>Testallkiri</translation>
-    </message>
     <message>
         <source>Signed on</source>
         <translation>Allkirjastatud</translation>

diff --git a/client/translations/ru.ts b/client/translations/ru.ts
@@ -2259,10 +2259,6 @@ and enter Smart-ID PIN2-code.</source>
         <source>AUTHORITY KEY IDENTIFIER</source>
         <translation>ИДЕНТИФИКАТОР ЛИЧНОГО КЛЮЧА</translation>
     </message>
-    <message>
-        <source>NB! TEST SIGNATURE</source>
-        <translation>NB! ПРОБНАЯ ПОДПИСЬ</translation>
-    </message>
     <message>
         <source>NB! WARNINGS</source>
         <translation>NB! ПРЕДУПРЕЖДЕНИЯ</translation>
@@ -2833,10 +2829,6 @@ Additional licenses and components</source>
         <source>This e-Signature is not equivalent with handwritten signature and therefore can be used only in transactions where Qualified e-Signature is not required.</source>
         <translation>Эта электронная подпись не эквивалентна рукописной подписи и поэтому может использоваться только в тех случаях, когда не требуется квалифицированная электронная подпись.</translation>
     </message>
-    <message>
-        <source>Test signature</source>
-        <translation>Пробная подпись</translation>
-    </message>
     <message>
         <source>is unknown</source>
         <comment>Signature</comment>
@@ -2861,10 +2853,6 @@ Additional licenses and components</source>
         <comment>Timestamp</comment>
         <translation>недействителен</translation>
     </message>
-    <message>
-        <source>Test signature is signed with test certificates that are similar to the certificates of real tokens, but digital signatures with legal force cannot be given with them as there is no actual owner of the card. &lt;a href=&apos;https://www.id.ee/en/article/verifying-signatures-given-with-test-certificates-in-the-digidoc4-client/&apos;&gt;Additional information&lt;/a&gt;.</source>
-        <translation>Пробная подпись создается пробным сертификатом, который отличается от настоящего тем, что с пробным сертификатом нельзя поставить юридически действительную подись, потому что владелец карты на самом деле не существует. &lt;a href=&apos;https://www.id.ee/en/article/verifying-signatures-given-with-test-certificates-in-the-digidoc4-client/&apos;&gt;Дополнительная информация&lt;/a&gt;.</translation>
-    </message>
     <message>
         <source>This is an invalid signature or malformed digitally signed file. The signature is not valid.</source>
         <translation>Повреждена подпись или подписанный файл. Данная подпись недействительна.</translation>
@@ -2977,10 +2965,6 @@ Additional licenses and components</source>
         <source>Restrictions</source>
         <translation>Ограничения</translation>
     </message>
-    <message>
-        <source>Test signature</source>
-        <translation>Пробная подпись</translation>
-    </message>
     <message>
         <source>Signature is valid</source>
         <translation>Подпись действительна</translation>

diff --git a/client/widgets/SignatureItem.cpp b/client/widgets/SignatureItem.cpp
@@ -118,9 +118,6 @@ void SignatureItem::init()
 	case DigiDocSignature::NonQSCD:
 		s << color(QLatin1String("green"), isValid()) << " " << color(QLatin1String("#996C0B"), QStringLiteral("(%1)").arg(tr("Restrictions")));
 		break;
-	case DigiDocSignature::Test:
-		s << color(QLatin1String("green"), isValid()) << " (" << tr("Test signature") << ")";
-		break;
 	case DigiDocSignature::Invalid:
 		ui->error = isSignature ? ria::qdigidoc4::InvalidSignatureWarning : ria::qdigidoc4::InvalidTimestampWarning;
 		s << color(QLatin1String("red"), isSignature ? tr("Signature is not valid") : tr("Timestamp is not valid"));
-Original file line number
+Diff line change
@@ Expand Up / @@ -38,7 +38,6 @@ class DigiDocSignature @@
     		Valid,
     		Warning,
     		NonQSCD,
-    		Test,
     		Invalid,
     		Unknown
     	};
@@ Expand Down @@