Handle ASiC-S XAdES signatures (open-eid#1203)

IB-7593

Signed-off-by: Raul Metsma <[email protected]>

client/DigiDoc.cpp

@@ -335,19 +335,17 @@ void SDocumentModel::open(int row)
 {
 	if(row >= rowCount())
 		return;
-
 	QString path = FileDialog::tempPath(FileDialog::safeName(from(doc->b->dataFiles().at(size_t(row))->fileName())));
 	if(!verifyFile(path))
 		return;
-	QFileInfo f(save(row, path));
-	if( !f.exists() )
+	if(!QFileInfo::exists(save(row, path)))
 		return;
-	doc->m_tempFiles.append(f.absoluteFilePath());
-	FileDialog::setReadOnly(f.absoluteFilePath());
-	if(!doc->fileName().endsWith(QStringLiteral(".pdf"), Qt::CaseInsensitive) && FileDialog::isSignedPDF(f.absoluteFilePath()))
-		qApp->showClient({ f.absoluteFilePath() }, false, false, true);
+	doc->m_tempFiles.append(path);
+	FileDialog::setReadOnly(path);
+	if(!doc->fileName().endsWith(QLatin1String(".pdf"), Qt::CaseInsensitive) && FileDialog::isSignedPDF(path))
+		qApp->showClient({ path }, false, false, true);
 	else
-		QDesktopServices::openUrl(QUrl::fromLocalFile(f.absoluteFilePath()));
+		QDesktopServices::openUrl(QUrl::fromLocalFile(path));
 }
 
 bool SDocumentModel::removeRow(int row)
@@ -447,11 +445,20 @@ bool DigiDoc::isError(bool failure, const QString &msg) const
 	return !b || failure;
 }
 
+bool DigiDoc::isAsicS() const
+{
+	return b && b->mediaType() == "application/vnd.etsi.asic-s+zip" &&
+		std::any_of(m_signatures.cbegin(), m_signatures.cend(), [](const DigiDocSignature &s) {
+			return s.profile().contains(QLatin1String("BES"), Qt::CaseInsensitive);
+		});
+}
+
 bool DigiDoc::isPDF() const
 {
 	return b && b->mediaType() == "application/pdf";
 }
 bool DigiDoc::isModified() const { return modified; }
+
 bool DigiDoc::isSupported() const
 {
 	return b && b->mediaType() == "application/vnd.etsi.asic-e+zip";
@@ -493,8 +500,8 @@ bool DigiDoc::open( const QString &file )
 		dlg->addButton(WarningDialog::YES, ContainerSave);
 		return dlg->exec() == ContainerSave;
 	};
-	if((file.endsWith(QStringLiteral(".pdf"), Qt::CaseInsensitive) ||
-		file.endsWith(QStringLiteral(".ddoc"), Qt::CaseInsensitive)) && !serviceConfirmation())
+	if((file.endsWith(QLatin1String(".pdf"), Qt::CaseInsensitive) ||
+		file.endsWith(QLatin1String(".ddoc"), Qt::CaseInsensitive)) && !serviceConfirmation())
 		return false;
 
 	try {

client/DigiDoc.h

@@ -126,6 +126,7 @@ class DigiDoc: public QObject
 	void clear();
 	DocumentModel *documentModel() const;
 	QString fileName() const;
+	bool isAsicS() const;
 	bool isPDF() const;
 	bool isModified() const;
 	bool isSupported() const;

client/common_enums.h

@@ -94,6 +94,7 @@ enum WarningType {
     InvalidTimestampWarning,
     UnknownSignatureWarning,
     UnknownTimestampWarning,
+    UnsupportedAsicSWarning,
     UnsupportedDDocWarning,
     EmptyFileWarning,
 };

client/dialogs/FileDialog.cpp

@@ -34,6 +34,7 @@
 #ifdef Q_OS_WIN
 #include <ShObjIdl.h>
 #include <ShlGuid.h>
+#include <fileapi.h>
 
 template <class T>
 class CPtr
@@ -125,19 +126,14 @@ int FileDialog::fileZone(const QString &path)
 
 bool FileDialog::isSignedPDF(const QString &path)
 {
-	const QFileInfo f(path);
-	if(f.suffix().compare(QStringLiteral("pdf"), Qt::CaseInsensitive))
+	if(!path.endsWith(QLatin1String("pdf"), Qt::CaseInsensitive))
 		return false;
 	QFile file(path);
 	if(!file.open(QIODevice::ReadOnly))
 		return false;
 	QByteArray blob = file.readAll();
-	for(const QByteArray &token: {"adbe.pkcs7.detached", "adbe.pkcs7.sha1", "adbe.x509.rsa_sha1", "ETSI.CAdES.detached"})
-	{
-		if(blob.indexOf(token) > 0)
-			return true;
-	}
-	return false;
+	static const auto list = {"adbe.pkcs7.detached", "adbe.pkcs7.sha1", "adbe.x509.rsa_sha1", "ETSI.CAdES.detached"};
+	return std::any_of(list.begin(), list.end(), [&blob](const char *token) { return blob.indexOf(token) > 0; });
 }
 
 void FileDialog::setFileZone(const QString &path, int zone)
@@ -290,7 +286,7 @@ QString FileDialog::getSaveFileName( QWidget *parent, const QString &caption,
 
 QString FileDialog::normalized(const QString &data)
 {
-	static constexpr std::array<const unsigned char[3],5> list = {{
+	static constexpr std::array<const unsigned char[3],5> list {{
 		{0xE2, 0x80, 0x8E}, // \u200E LEFT-TO-RIGHT MARK
 		{0xE2, 0x80, 0x8F}, // \u200F RIGHT-TO-LEFT MARK
 		{0xE2, 0x80, 0xAA}, // \u202A LEFT-TO-RIGHT EMBEDDING
@@ -340,15 +336,16 @@ QString FileDialog::safeName(const QString &file)
 	QString filename = info.fileName();
 #if defined(Q_OS_WIN)
 	static const QStringList disabled { "CON", "PRN", "AUX", "NUL",
-										"COM1", "COM2", "COM3", "COM4", "COM5", "COM6", "COM7", "COM8", "COM9",
-										"LPT1", "LPT2", "LPT3", "LPT4", "LPT5", "LPT6", "LPT7", "LPT8", "LPT9" };
+		"COM1", "COM2", "COM3", "COM4", "COM5", "COM6", "COM7", "COM8", "COM9",
+		"LPT1", "LPT2", "LPT3", "LPT4", "LPT5", "LPT6", "LPT7", "LPT8", "LPT9" };
 	if(disabled.contains(info.baseName(), Qt::CaseInsensitive))
 		filename = QStringLiteral("___.") + info.suffix();
-	filename.replace(QRegularExpression(QStringLiteral("[\\\\/*:?\"<>|]")), QStringLiteral("_"));
+	static const QRegularExpression replace(QStringLiteral("[\\\\/*:?\"<>|]"));
 #elif defined(Q_OS_MAC)
-	filename.replace(QRegularExpression(QStringLiteral("[\\\\/:]")), QStringLiteral("_"));
+	static const QRegularExpression replace(QStringLiteral("[\\\\/:]"));
 #else
-	filename.replace(QRegularExpression(QStringLiteral("[\\\\/]")), QStringLiteral("_"));
+	static const QRegularExpression replace(QStringLiteral("[\\\\/]"));
 #endif
+	filename.replace(replace, QStringLiteral("_"));
 	return filename;
 }

client/translations/en.ts

@@ -3288,6 +3288,10 @@ Additional licenses and components</translation>
         <source>Certificates expire soon! </source>
         <translation>Certificates expire soon! </translation>
     </message>
+    <message>
+        <source>This ASiC-S container contains XAdES signature. You are not allowed to add or remove signatures to this container.</source>
+        <translation>This ASiC-S container contains XAdES signature. You are not allowed to add or remove signatures to this container.</translation>
+    </message>
 </context>
 <context>
     <name>WarningRibbon</name>

client/translations/et.ts

@@ -3288,6 +3288,10 @@ Täiendavad litsentsid ja komponendid</translation>
         <source>Certificates have expired! </source>
         <translation>Sertifikaadid on aegunud! </translation>
     </message>
+    <message>
+        <source>This ASiC-S container contains XAdES signature. You are not allowed to add or remove signatures to this container.</source>
+        <translation>Tegemist on XAdES allkirja sisalduva ASiC-S ümbrikuga. Sellele ümbrikule ei saa allkirja lisada ega eemaldada.</translation>
+    </message>
 </context>
 <context>
     <name>WarningRibbon</name>

client/translations/ru.ts

@@ -3293,6 +3293,10 @@ Additional licenses and components</source>
         <source>Certificates expire soon! </source>
         <translation>Срок действия сертификатов скоро истекает! </translation>
     </message>
+    <message>
+        <source>This ASiC-S container contains XAdES signature. You are not allowed to add or remove signatures to this container.</source>
+        <translation>Речь идет о конверте ASiC-S, содержащемся в подписи XAdES. К данному контейнеру нельзя добавить или удалить из него подпись.</translation>
+    </message>
 </context>
 <context>
     <name>WarningRibbon</name>

client/widgets/ContainerPage.cpp

@@ -332,6 +332,8 @@ void ContainerPage::transition(DigiDoc* container)
 		emit warning(WarningText(i.key(), i.value()));
 	if(container->fileName().endsWith(QStringLiteral("ddoc"), Qt::CaseInsensitive))
 		emit warning(UnsupportedDDocWarning);
+	if(container->isAsicS())
+		emit warning(UnsupportedAsicSWarning);
 
 	hasEmptyFile = false;
 	for (auto i = 0; i < container->documentModel()->rowCount(); i++)

client/widgets/WarningItem.cpp

@@ -134,6 +134,13 @@ void WarningItem::lookupWarning()
 		warnText.details = tr("More information");
 		warnText.page = ria::qdigidoc4::SignDetails;
 		break;
+	case ria::qdigidoc4::UnsupportedAsicSWarning:
+		warnText.text = tr("This ASiC-S container contains XAdES signature. "
+			"You are not allowed to add or remove signatures to this container.");
+		warnText.url = tr("https://www.id.ee/en/article/digidoc-container-format-life-cycle-2/");
+		warnText.details = tr("More information");
+		warnText.page = ria::qdigidoc4::SignDetails;
+		break;
 	case ria::qdigidoc4::UnsupportedDDocWarning:
 		warnText.text = tr("The current file is a DigiDoc container that is not supported officially any longer. You are not allowed to add or remove signatures to this container.");
 		warnText.url = tr("https://www.id.ee/en/article/digidoc-container-format-life-cycle-2/");