run rector

mewebstudio · Mar 23, 2024 · 8ed7280 · 8ed7280
1 parent 805f9dc
commit 8ed7280
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 9 deletions.
diff --git a/src/DataMapper/ResponseDataMapper/EstPosResponseDataMapper.php b/src/DataMapper/ResponseDataMapper/EstPosResponseDataMapper.php
@@ -135,7 +135,7 @@ public function map3DPaymentData(array $raw3DAuthResponseData, ?array $rawPaymen
             'eci'                  => null,
             'tx_status'            => null,
             'cavv'                 => null,
-            'md_error_message'     => !$this->is3dAuthSuccess($mdStatus) ? $raw3DAuthResponseData['mdErrorMsg'] : null,
+            'md_error_message'     => $this->is3dAuthSuccess($mdStatus) ? null : $raw3DAuthResponseData['mdErrorMsg'],
             '3d_all'               => $raw3DAuthResponseData,
         ];
 
@@ -450,7 +450,7 @@ public function mapHistoryResponse(array $rawResponseData): array
      */
     public function is3dAuthSuccess(?string $mdStatus): bool
     {
-        return \in_array($mdStatus, ['1'], true);
+        return $mdStatus === '1';
     }
 
     /**

diff --git a/src/DataMapper/ResponseDataMapper/PayForPosResponseDataMapper.php b/src/DataMapper/ResponseDataMapper/PayForPosResponseDataMapper.php
@@ -384,7 +384,7 @@ public function mapHistoryResponse(array $rawResponseData): array
      */
     public function is3dAuthSuccess(?string $mdStatus): bool
     {
-        return \in_array($mdStatus, ['1'], true);
+        return $mdStatus === '1';
     }
 
     /**

diff --git a/src/DataMapper/ResponseDataMapper/PosNetV1PosResponseDataMapper.php b/src/DataMapper/ResponseDataMapper/PosNetV1PosResponseDataMapper.php
@@ -293,7 +293,7 @@ public function mapOrderHistoryResponse(array $rawResponseData): array
      */
     public function is3dAuthSuccess(?string $mdStatus): bool
     {
-        return \in_array($mdStatus, ['1'], true);
+        return $mdStatus === '1';
     }
 
     /**

diff --git a/src/DataMapper/ResponseDataMapper/ToslaPosResponseDataMapper.php b/src/DataMapper/ResponseDataMapper/ToslaPosResponseDataMapper.php
@@ -319,7 +319,7 @@ public function mapHistoryResponse(array $rawResponseData): array
      */
     public function is3dAuthSuccess(?string $mdStatus): bool
     {
-        return \in_array($mdStatus, ['1'], true);
+        return $mdStatus === '1';
     }
 
     /**

diff --git a/src/Gateways/ToslaPos.php b/src/Gateways/ToslaPos.php
@@ -98,10 +98,8 @@ public function make3DPayPayment(Request $request, array $order, string $txType)
     {
         $request = $request->request;
 
-        if ($this->is3DAuthSuccess($request->all())) {
-            if (!$this->requestDataMapper->getCrypt()->check3DHash($this->account, $request->all())) {
-                throw new HashMismatchException();
-            }
+        if ($this->is3DAuthSuccess($request->all()) && !$this->requestDataMapper->getCrypt()->check3DHash($this->account, $request->all())) {
+            throw new HashMismatchException();
         }
 
         $this->response = $this->responseDataMapper->map3DPayResponseData($request->all(), $txType, $order);
-Original file line number
+Diff line change
@@ Expand Up @@
          */
         public function is3dAuthSuccess(?string $mdStatus): bool
         {
-            return \in_array($mdStatus, ['1'], true);
+            return $mdStatus === '1';
         }
         /**
@@ Expand Down @@