Likeno #103
Merged
Likeno #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diego Araújo <[email protected]>
- Remove unnecessary initialization from env - Use Likeno to configure the paths to be used to clean external databases Signed-off-by: Diego Araújo <[email protected]>
Signed off by: Rafael Reggiani Manzo <[email protected]>
This fails because Likeno hash conversion needs to get fixed first. Likeno adds new custom headers and prefixes functionality, which then required adaptations here. Base#convert_to_hash handles conversion from classes within Miscellaneous modules. Base#is_valid? has been renamed to Base#valid?. This may be a error of ours. If other applications require this method we will need to restore `is_valid?` as a deprecated alias to `valid?`. Just as `kalibro_errors`. Processor::Base and configurations::Base required adaptations as well to correctly pull the `address` from configuration files. Signed off by: Diego Araújo <[email protected]>
This fixes the hash conversion bug so now we expect all tests to pass. Signed off by: Rafael Reggiani Manzo <[email protected]>
This adds more complete hash conversion which fixes Miscellaneous module classes conversion to hash and enables us to remove one workaround on Base. Signed off by: Diego Araújo <[email protected]>
After the introduction of Likeno, `KalibroClient::Errors` has become `Likeno::Errors`.
This was legacy code from distant times where Kalibro used SOAP for communication.
|
ping @danielkza and @dread-uo |
| @@ -47,4 +47,5 @@ Gem::Specification.new do |spec| | |||
|
|
|||
| spec.add_dependency "activesupport", ">= 2.2.1" #version in which underscore was introduced | |||
| spec.add_dependency "faraday_middleware", "~> 0.9" | |||
| spec.add_dependency "likeno", ">= 1.1", "< 2" | |||
|
It seems good to me. Great job! 👍 |
| @@ -1,4 +1,4 @@ | |||
| # This file is part of KalibroClient | |||
| # This file is part of KalibroClient | |||
There was a problem hiding this comment.
This extra space seems accidental.
Since the same errors are raised, we do not need to duplicate the code. Notice that this breaks the KalibroClient API. Signed-off-by: Daniel Miranda <[email protected]>
Signed-off-by: Daniel Miranda <[email protected]>
Signed-off-by: Diego Araújo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full integration of Likeno on KalibroClient.
We are now using
Likeno::Entityas base for our KalibroClient's models. We adapted the code accordingly. We've deprecated thekalibro_errorsmethod. On future versions it will be calledlikeno_errors. To complete the integration we implemented themodule_namemethod.Also remove the method
allfrom the classes that implemented it, since Likeno has a default implementation that is enough for our needs.Remove unused XML converter methods. They were legacy code from old Kalibro.
Use
Likeno::Errors::Standardas the default error class.