Optimize TreeMetricResult#descendant_values #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation was incredibly sub-optimal. It can be easily replaced with a join on the parent_id.
|
Here are some tests on my machine, including max. resident RAM (all using 8 metrics). Files are named for the respective branches. Gist. In short, this is a really (almost 100%) performance good improvement by itself, but still quite a bit worse than the full aggregation rewrite (which actually doesn't even use 👍 for me |
It was only used by the old version of TreeMetricResult#descendant_values.
|
Even tough this will have no impact on aggregation after #225, it will still be used for Nice job! (I've removed some code made useless by this) |
|
Right, I missed that. Nice catch on the useless code! |
| self.class. | ||
| joins(:module_result). | ||
| where('module_results.parent_id' => module_result_id). | ||
| pluck(:value) |
|
Great job, guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was incredibly sub-optimal. It can be easily
replaced with a join on the parent_id.
Aggregation performance test results below:
@mezuro/core we need a third pair of eyes here as well.
This is part of #207.