Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows #218

Merged
merged 80 commits into from
Apr 23, 2024
Merged

Workflows #218

merged 80 commits into from
Apr 23, 2024

Conversation

justinlaughlin
Copy link
Contributor

Do not merge

I'm trying to test a workflow file but according to what I've read on stack exchange, github needs a pull request to register the workflow before it can be triggered manually.

https://stackoverflow.com/questions/63362126/github-actions-how-to-run-a-workflow-created-on-a-non-master-branch-from-the-wo

@justinlaughlin justinlaughlin self-assigned this Apr 5, 2024
@sshiraiwa sshiraiwa added the in-test-with-mfem-master trigger a workflow to test using MFEM master label Apr 8, 2024
@justinlaughlin justinlaughlin added in-test-with-mfem-master trigger a workflow to test using MFEM master and removed in-test-with-mfem-master trigger a workflow to test using MFEM master labels Apr 16, 2024
@sshiraiwa
Copy link
Member

Merging this PR. The build error with MFEM master will be address in next PR.

@sshiraiwa sshiraiwa marked this pull request as ready for review April 20, 2024 02:16
@sshiraiwa
Copy link
Member

Well. I noticed it is still in draft mode. @justinlaughlin, please confirm that it is ready to review and merge.

@justinlaughlin
Copy link
Contributor Author

It is ready to merge - does it still say draft mode? I'll add in the option for triggering off of base MFEM in a separate branch.

Copy link
Member

@sshiraiwa sshiraiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvement. I will merge this. I suppose that some test with master will still fail because ex18/ex18p were updated. Otherwise, it should go through. Let's see.

@sshiraiwa sshiraiwa merged commit 34f96a9 into master Apr 23, 2024
11 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-test-with-mfem-master trigger a workflow to test using MFEM master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants