FIX: Give Optionals a default value

mferrera · Sep 26, 2024 · c22798c · c22798c
1 parent a26bac7
commit c22798c
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 12 deletions.
diff --git a/schema/definitions/0.8.0/schema/fmu_results.json b/schema/definitions/0.8.0/schema/fmu_results.json
@@ -2862,6 +2862,7 @@
               "type": "null"
             }
           ],
+          "default": null,
           "examples": [
             "kjhsdfvsdlfk23knerknvk23"
           ],
@@ -2900,8 +2901,7 @@
         }
       },
       "required": [
-        "relative_path",
-        "checksum_md5"
+        "relative_path"
       ],
       "title": "File",
       "type": "object"
@@ -5499,7 +5499,6 @@
         }
       },
       "required": [
-        "attributes",
         "size"
       ],
       "title": "PointSpecification",

diff --git a/src/fmu/dataio/_model/data.py b/src/fmu/dataio/_model/data.py
@@ -46,10 +46,10 @@ class Time(BaseModel):
 
     .. note:: ``data.time`` items can currently hold a maximum of two values."""
 
-    t0: Optional[Timestamp] = None
+    t0: Optional[Timestamp] = Field(default=None)
     """The first timestamp. See :class:`Timestamp`."""
 
-    t1: Optional[Timestamp] = None
+    t1: Optional[Timestamp] = Field(default=None)
     """The second timestamp. See :class:`Timestamp`."""
 
 
@@ -65,16 +65,16 @@ class Seismic(BaseModel):
     calculation: Optional[str] = Field(default=None, examples=["mean"])
     """The type of calculation applied."""
 
-    filter_size: Optional[float] = Field(allow_inf_nan=False, default=None)
+    filter_size: Optional[float] = Field(default=None, allow_inf_nan=False)
     """The filter size applied."""
 
-    scaling_factor: Optional[float] = Field(allow_inf_nan=False, default=None)
+    scaling_factor: Optional[float] = Field(default=None, allow_inf_nan=False)
     """The scaling factor applied."""
 
     stacking_offset: Optional[str] = Field(default=None, examples=["0-15"])
     """The stacking offset applied."""
 
-    zrange: Optional[float] = Field(allow_inf_nan=False, default=None)
+    zrange: Optional[float] = Field(default=None, allow_inf_nan=False)
     """The z-range of these data."""
 
 
@@ -305,13 +305,13 @@ class Data(BaseModel):
     """Column names in the table which can be used for indexing. Only applicable if the
     data object is a table."""
 
-    base: Optional[Layer] = None
+    base: Optional[Layer] = Field(default=None)
     """If the data represent an interval, this field can be used to represent its base.
     See :class:`Layer`.
 
     .. note:: ``top`` is required to use with this."""
 
-    top: Optional[Layer] = None
+    top: Optional[Layer] = Field(default=None)
     """If the data represent an interval, this field can be used to represent its top.
     See :class:`Layer`.
 

diff --git a/src/fmu/dataio/_model/fields.py b/src/fmu/dataio/_model/fields.py
@@ -103,7 +103,9 @@ class File(BaseModel):
     )
     """The path of a file relative to the case root."""
 
-    checksum_md5: Optional[str] = Field(examples=["kjhsdfvsdlfk23knerknvk23"])
+    checksum_md5: Optional[str] = Field(
+        default=None, examples=["kjhsdfvsdlfk23knerknvk23"]
+    )
     """A valid MD5 checksum of the file."""
 
     size_bytes: Optional[int] = Field(default=None)

diff --git a/src/fmu/dataio/_model/specification.py b/src/fmu/dataio/_model/specification.py
@@ -52,7 +52,7 @@ class SurfaceSpecification(RowColumn):
 class PointSpecification(BaseModel):
     """Specifies relevant values describing an xyz points object."""
 
-    attributes: Optional[List[str]]
+    attributes: Optional[List[str]] = Field(default_factory=list)
     """List of columns present in a table."""
 
     size: int = Field(examples=[1, 9999])