Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support speaker notes #389

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

feat: support speaker notes #389

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
de42655
add speaker notes mode cli option
dmackdev Nov 4, 2024
fd6d57b
use ipc to navigate to specfic slides in speaker notes presentation w…
dmackdev Nov 5, 2024
3151fbd
process only speaker notes and end slide comments when in speaker not…
dmackdev Nov 5, 2024
cbadf07
fix layout on speaker note slides
dmackdev Nov 6, 2024
93a0dcb
move `SpeakerNotesChannel` to `Presenter` from `PresentationStateInner`
dmackdev Nov 8, 2024
22d70f7
restore original examples/code.md
dmackdev Nov 8, 2024
4c7726e
add speaker notes example presentation
dmackdev Nov 8, 2024
df051d3
show titles in speaker notes mode
dmackdev Nov 8, 2024
81cfbbc
remove ipc event service duplication
dmackdev Nov 8, 2024
4416af8
remove SpeakerNoteChannel enum
dmackdev Nov 11, 2024
5f781ac
bump CI rust version to 1.75.0
dmackdev Nov 11, 2024
0fd812e
Merge remote-tracking branch 'origin/master' into speaker-notes
dmackdev Nov 11, 2024
0f83b5a
split process_element for speaker notes and presentation modes
dmackdev Nov 11, 2024
dc0e039
fix formatting
dmackdev Nov 16, 2024
27a6151
use pubsub ipc messaging pattern instead of event
dmackdev Nov 16, 2024
43b44c5
incorporate presentation file name in ipc service name
dmackdev Nov 17, 2024
ddbaf41
split process comment command for speaker notes mode
dmackdev Nov 19, 2024
3114df9
propagate iceoryx2 publisher errors
dmackdev Nov 19, 2024
52d3f04
propagate iceoryx2 receiver error
dmackdev Nov 19, 2024
13e2d46
send new SpeakerNotesCommand::Exit ipc message to exit the speaker no…
dmackdev Nov 21, 2024
2964ac9
use string interpolation for ipc service name
dmackdev Nov 21, 2024
209cd10
propagate error instead of expect
dmackdev Nov 21, 2024
64dcc88
set iceoryx2 log level to error to hide misleading "missing config" w…
dmackdev Dec 4, 2024
7924524
add better error messages for iceoryx2 service open/create errors
dmackdev Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/merge.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
uses: actions/checkout@v4

- name: Install rust toolchain
uses: dtolnay/rust-toolchain@1.74.0
uses: dtolnay/rust-toolchain@1.75.0

- name: Run cargo check
run: cargo check --features sixel
Expand All @@ -28,7 +28,7 @@ jobs:
uses: actions/checkout@v4

- name: Install rust toolchain
uses: dtolnay/rust-toolchain@1.74.0
uses: dtolnay/rust-toolchain@1.75.0

- name: Run cargo test
run: cargo test
Expand Down
Loading
Loading