Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added width and height base zooming insted of scaleing doc #1536

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added width and height base zooming insted of scaleing doc #1536

wants to merge 4 commits into from

Conversation

AshishViradiya153
Copy link
Contributor

@AshishViradiya153 AshishViradiya153 requested a review from mfts as a code owner March 4, 2025 05:03
@vercel Vercel
Copy link

vercel bot commented Mar 4, 2025

@AshishViradiya153 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

mfts
mfts requested changes Mar 4, 2025
View reviewed changes
Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshishViradiya153 looks great so far.

There are two issues:

  • watermarks are not scaling with the document's new dimensions
  • link box coordinates on documents with embedded links are not scaling

https://www.loom.com/share/cec7ec2bcfbb45098dce71f4878e7611

Let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfts mfts mfts requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AshishViradiya153 @mfts