Added option to prevent Prefix being added to output path #301
Conversation
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
==========================================
- Coverage 95.67% 95.39% -0.29%
==========================================
Files 19 19
Lines 3310 3324 +14
Branches 484 486 +2
==========================================
+ Hits 3167 3171 +4
- Misses 82 90 +8
- Partials 61 63 +2
Continue to review full report at Codecov.
|
|
thinking about it, using String.Replace could cause problems if a short Prefix was used. A substring would be better. I will update if this Pull Request is something you would consider. |
| @@ -87,6 +88,7 @@ static void Main(string[] args) | |||
| { "r|order", "emit order for all class members stored as XML element", v => emitOrder = v != null }, | |||
| { "c|pcl", "PCL compatible output", v => pclCompatible = v != null }, | |||
| { "p|prefix=", "the {PREFIX} to prepend to auto-generated namespace names", v => namespacePrefix = v }, | |||
| { "po|prefixOnOutput", "include the prefix on the path (default is enabled)", v => addPrefixToOutputPath = v != null }, | |||
There was a problem hiding this comment.
IMO the phrasing can be improved here. Perhaps: "po|prefixPath", "include namespace prefix in output paths (default is enabled)"
|
Thank you for this PR. If you use Please also add unit tests. |
Yes, this causes issues because of that so will close this. I am getting different results running the original version through a library vs the exe. Currently investigating. (when ran through via the exe it always seems to get added). |
Pull request for #300