Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.12 #45

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Support Python 3.12 #45

merged 3 commits into from
Oct 4, 2023

Conversation

mgedmin
Copy link
Owner

@mgedmin mgedmin commented Oct 3, 2023

No description provided.

@mgedmin
Copy link
Owner Author

mgedmin commented Oct 3, 2023

The failure is coverage < 100% on Python 3.12, which at first seems to be nedbat/coveragepy#1640 (forwarded to python/cpython#105658 and fixed in 3.12rc3). But GitHub Actions gets us 3.12.0, with the fix, and still the bug is there.

Locally I cannot reproduce with a git build of Python 3.12+ (git described as v3.12.0-77-g64afbf6f28).

A brief look at all 77 commits since 3.12.0 doesn't show anything related to tracing.

The log of the GitHub Actions build shows it is downloading a 3.12.0 tarball.

It is a mystery.

@mgedmin
Copy link
Owner Author

mgedmin commented Oct 3, 2023

Windows builds are failing because setuptools is not installed by default in whatever Python that find_python() returns.

Our test suite expects 'python' in %PATH% to have setuptools available.
@mgedmin
Copy link
Owner Author

mgedmin commented Oct 4, 2023

The failure is coverage < 100% on Python 3.12, which at first seems to be nedbat/coveragepy#1640 (forwarded to python/cpython#105658 and fixed in 3.12rc3). But GitHub Actions gets us 3.12.0, with the fix, and still the bug is there.

That issue is unrelated; the issue here is we're using coverage 6.5.0 without proper Python 3.12 support, and we're using it because coveralls does not support coverage 7.x.

Because the command-line coveralls tool pins coverage < 7.0, which
doesn't work well on Python 3.12.

Also update all the GitHub actions to the latest versions and tweak YAML
formatting so all the shell commands are aligned.
@mgedmin mgedmin merged commit fcbf077 into master Oct 4, 2023
11 checks passed
@mgedmin mgedmin deleted the py312 branch October 4, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant