[Code] Go wild and add an explanation why we want to keep the @phpsta…

…n-ignore-next-line in these cases
mglaman · Nov 15, 2024 · 2e6774e · 2e6774e
1 parent 9262974
commit 2e6774e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/Rules/Deprecations/SymfonyCmfRouteObjectInterfaceConstantsRule.php b/src/Rules/Deprecations/SymfonyCmfRouteObjectInterfaceConstantsRule.php
@@ -50,6 +50,8 @@ public function processNode(Node $node, Scope $scope): array
         }
 
         // The next line is intentionally not using [at]phpstan-ignore [identifier].
+        // The identifier would be 'class.notFound', which would not be true in
+        // case of a D9 scan and thus would fail the 'phpstan analyze' phase.
         // @phpstan-ignore-next-line
         $cmfRouteObjectInterfaceType = new ObjectType(SymfonyRouteObjectInterface::class);
         if (!$classType->isSuperTypeOf($cmfRouteObjectInterfaceType)->yes()) {

diff --git a/src/Rules/Deprecations/SymfonyCmfRoutingInClassMethodSignatureRule.php b/src/Rules/Deprecations/SymfonyCmfRoutingInClassMethodSignatureRule.php
@@ -40,6 +40,8 @@ public function processNode(Node $node, Scope $scope): array
         $method = $node->getMethodReflection();
 
         // The next lines are intentionally not using [at]phpstan-ignore [identifier].
+        // The identifier would be 'class.notFound', which would not be true in
+        // case of a D9 scan and thus would fail the 'phpstan analyze' phase.
         // @phpstan-ignore-next-line
         $cmfRouteObjectInterfaceType = new ObjectType(RouteObjectInterface::class);
         // @phpstan-ignore-next-line