Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the discovered Drupal extensions accessible via a service #264

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

brambaud
Copy link
Contributor

@brambaud brambaud commented Dec 1, 2021

See #249

Just to open discussion

src/Drupal/ExtensionMap.php Outdated Show resolved Hide resolved
src/Drupal/ModuleExtension.php Outdated Show resolved Hide resolved
@brambaud brambaud force-pushed the issue/249 branch 2 times, most recently from ced39a3 to 6892d6e Compare December 10, 2021 17:19
@mglaman mglaman marked this pull request as ready for review December 15, 2021 20:11
Copy link
Owner

@mglaman mglaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expanded this to reduce code in the load include rules. I noticed that all of the ExtensionMap getters are null since data is not keyed by module name when set. Pushing fix with refactored load includes code

src/Drupal/ExtensionMap.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants