Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include bits/stdc++.h only when using libstdc++ #56

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

kraj
Copy link
Contributor

@kraj kraj commented Nov 13, 2023

We have other c++ runtime implementations e.g. llvm's libc++ which does not provide this header bits/stdc++.h, therefore make sure that this header is only included when using libstdc++

Fixes
| /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/cannelloni/1.1.0/git/tcpthread.cpp:27:10: fatal error: 'bits/stdc++.h' file not found
| 27 | #include <bits/stdc++.h>
| | ^~~~~~~~~~~~~~~

kraj added a commit to kraj/cannelloni that referenced this pull request Nov 13, 2023
We have other c++ runtime implementations e.g. llvm's libc++ which does
not provide this header bits/stdc++.h, therefore make sure that this
header is only included when using libstdc++

Fixes
| /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/cannelloni/1.1.0/git/tcpthread.cpp:27:10: fatal error: 'bits/stdc++.h' file not found
|    27 | #include <bits/stdc++.h>
|       |          ^~~~~~~~~~~~~~~

Upstream-Status: Submitted [mguentner#56]
Signed-off-by: Khem Raj <[email protected]>
@mguentner
Copy link
Owner

Thanks for this! Could you please rebase your branch?

We have other c++ runtime implementations e.g. llvm's libc++ which does
not provide this header bits/stdc++.h, therefore make sure that this
header is only included when using libstdc++

Fixes
| /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/cannelloni/1.1.0/git/tcpthread.cpp:27:10: fatal error: 'bits/stdc++.h' file not found
|    27 | #include <bits/stdc++.h>
|       |          ^~~~~~~~~~~~~~~

Upstream-Status: Submitted [mguentner#56]
Signed-off-by: Khem Raj <[email protected]>
@kraj
Copy link
Contributor Author

kraj commented Nov 14, 2023

Thanks for this! Could you please rebase your branch?

done

@mguentner mguentner merged commit 102ee4f into mguentner:master Nov 15, 2023
2 checks passed
@mguentner
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants