Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3.7 #530

Merged
merged 26 commits into from
Dec 1, 2023
Merged

Release 0.3.7 #530

merged 26 commits into from
Dec 1, 2023

Conversation

mhostetter
Copy link
Owner

No description provided.

istankovic and others added 26 commits October 2, 2023 16:25
If `Self + NDArray` is performed, this prevents `mypy` from falling back to `ndarray.__radd__()`, which has a return type of `NDArray`. This ensures that the arithmetic type is always `Self`. The runtime type checking will ensure valid arguments are passed.
Also, it fixes the bug of skipping the first two numbers after n. For example, in the previous version:

>>> galois.next_prime(100000034)
100000037

>>> galois.next_prime(100000035)
100000039

>>> galois.next_prime(100000036)
100000039

>>> galois.next_prime(100000037)
100000049
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (99e91d9) 96.34% compared to head (a0c03ba) 96.43%.

Files Patch % Lines
src/galois/_domains/_array.py 85.45% 8 Missing ⚠️
src/galois/_prime.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
+ Coverage   96.34%   96.43%   +0.08%     
==========================================
  Files          46       46              
  Lines        5848     5911      +63     
==========================================
+ Hits         5634     5700      +66     
+ Misses        214      211       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhostetter mhostetter merged commit 529ba26 into main Dec 1, 2023
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants