-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.3.7 #530
Merged
Merged
Release 0.3.7 #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `Self + NDArray` is performed, this prevents `mypy` from falling back to `ndarray.__radd__()`, which has a return type of `NDArray`. This ensures that the arithmetic type is always `Self`. The runtime type checking will ensure valid arguments are passed.
Fixes #523
Also, it fixes the bug of skipping the first two numbers after n. For example, in the previous version: >>> galois.next_prime(100000034) 100000037 >>> galois.next_prime(100000035) 100000039 >>> galois.next_prime(100000036) 100000039 >>> galois.next_prime(100000037) 100000049
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #530 +/- ##
==========================================
+ Coverage 96.34% 96.43% +0.08%
==========================================
Files 46 46
Lines 5848 5911 +63
==========================================
+ Hits 5634 5700 +66
+ Misses 214 211 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.