Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Template Review #248

Merged
merged 22 commits into from
Oct 12, 2022

Conversation

danibix95
Copy link
Contributor

@danibix95 danibix95 commented May 30, 2022

Hi,

in this PR it is proposed a new base configuration for lc39 Typescript template. The changes include:

  • update Node JS version (from v14 to v16)
  • swap Jest with Tap as test framework
  • split Typescript test configuration from the build one to allow greater flexibility
  • allow running tests in "unsafe mode", which means code is only transpiled before tests execution and no type check is performed (see @swc-node/register).
    Note: at build time types are checked
  • update service dependencies
  • fix linting and add further eslint config for typescript
  • updat Github action

package.json Outdated Show resolved Hide resolved
.husky/pre-commit Outdated Show resolved Hide resolved
.swcrc Outdated Show resolved Hide resolved
__tests__/config.ts Outdated Show resolved Hide resolved
__tests__/helpers/index.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
scripts/prepare.js Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@danibix95 danibix95 requested a review from fredmaggiowski May 31, 2022 22:11
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@GioAc96
Copy link
Contributor

GioAc96 commented Jun 7, 2022

Non mi torna l'uso di swc e tsc usato con emitDeclarationOnly. Ho fatto un test e tsc non è più veloce con emitDeclarationOnly perchè la parte lenta non è la transpilazione di TS, quanto il type checking (che non viene skippato).

@danibix95 danibix95 requested a review from ilteoood June 7, 2022 20:26
Dockerfile Outdated Show resolved Hide resolved
Included changes aim to provide a simpler base template, retaining type checking but also reducing time to run tests. In addition Jest is swapped with Tap and swc is employed only for test transpiling, while tsc is still employed for building the source code.

BREAKING CHANGE:
@danibix95 danibix95 changed the title Typescript Improvements and SWC introduction Typescript Template Review Aug 16, 2022
Dockerfile Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Co-authored-by: Giorgio Acquati <[email protected]>
.dockerignore Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
build.tsconfig.json Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
@danibix95 danibix95 requested review from fredmaggiowski and removed request for davidetan October 12, 2022 12:06
@fredmaggiowski fredmaggiowski merged commit 26fd8f9 into mia-platform-marketplace:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants