-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript Template Review #248
Merged
fredmaggiowski
merged 22 commits into
mia-platform-marketplace:master
from
danibix95:master
Oct 12, 2022
Merged
Typescript Template Review #248
fredmaggiowski
merged 22 commits into
mia-platform-marketplace:master
from
danibix95:master
Oct 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidetan
reviewed
May 30, 2022
fredmaggiowski
requested changes
May 30, 2022
ilteoood
reviewed
Jun 7, 2022
ilteoood
reviewed
Jun 7, 2022
ilteoood
reviewed
Jun 7, 2022
ilteoood
reviewed
Jun 7, 2022
Non mi torna l'uso di |
Included changes aim to provide a simpler base template, retaining type checking but also reducing time to run tests. In addition Jest is swapped with Tap and swc is employed only for test transpiling, while tsc is still employed for building the source code. BREAKING CHANGE:
danibix95
changed the title
Typescript Improvements and SWC introduction
Typescript Template Review
Aug 16, 2022
ilteoood
reviewed
Aug 16, 2022
GioAc96
reviewed
Aug 29, 2022
Co-authored-by: Giorgio Acquati <[email protected]>
fredmaggiowski
requested changes
Sep 5, 2022
danibix95
requested review from
fredmaggiowski
and removed request for
davidetan
October 12, 2022 12:06
fredmaggiowski
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in this PR it is proposed a new base configuration for
lc39
Typescript template. The changes include:Note: at build time types are checked
eslint
config for typescript