Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move json-schema-to-ts devDependency to dependency #360

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: move json-schema-to-ts devDependency to dependency #360

wants to merge 2 commits into from

Conversation

ThisIsDemetrio
Copy link
Contributor

Included json-schema-to-ts from dependency to allow to include the library in applications that does not have json-schema-to-ts in their depdendency. This will allow these applications to generate schemas on the fly.

PR proposed by @ianFar96

@ThisIsDemetrio ThisIsDemetrio requested a review from a team as a code owner January 15, 2025 11:42
fredmaggiowski
fredmaggiowski approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredmaggiowski fredmaggiowski fredmaggiowski approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThisIsDemetrio @fredmaggiowski