Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing customMetrics from DecoratedFastify type #226

Open
danibix95 opened this issue May 12, 2022 · 0 comments
Open

Missing customMetrics from DecoratedFastify type #226

danibix95 opened this issue May 12, 2022 · 0 comments
Assignees

Comments

@danibix95
Copy link
Contributor

Hi,

using custom-plugin-lib with Typescript I noticed that DecoratedFastify type is missing the optional field customMetrics containing all the custom metrics defined for a service.

Proposal

I would propose to add it, so that it is not necessary to extend the type to use custom metrics when they are enabled.
This could be achieved editing DecoratedFastify interface, adding the following field definition:

...
customMetrics?: Record<string, Metric<string>>
...

Your environment

node: v16
npm: 8.5.0

custom-plugin-lib: v4.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants