Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Switch): added Switch component #683

Merged
merged 14 commits into from
Oct 30, 2024
Merged

feat(Switch): added Switch component #683

merged 14 commits into from
Oct 30, 2024

Conversation

GiovannaMonti
Copy link
Contributor

@GiovannaMonti GiovannaMonti commented Oct 30, 2024

Description

This PR introduces the Switch component. For now, it is a single component. Once we approve the development of component groups (discussion is in progress on issue #682), we will also create the SwitchGroup component.

image

[IMPORTANT] PR Checklist

  • I am aware of standards and conventions adopted in this repository, defined in the CONTRIBUTING.md file

PR conventions

Please make sure your PR complies with the following rules before submitting it.

  • PR title follows the <type>(<scope>): <subject> structure
  • The PR has been labeled according to the type of changes (e.g., enhancement, bug).

Additional code checks

Based on your changes, some of these checks may not apply. Please make sure to check the relevant items in the list.

  • Changes are covered by tests
  • Changes to components are accessible and documented in the Storybook
  • Typings have been updated
  • New components are exported from the index file
  • New files include the Apache 2.0 License disclaimer
  • The browser console does not contain errors

@GiovannaMonti GiovannaMonti added enhancement New feature or request Switch component Switch component and hooks related activities labels Oct 30, 2024
@GiovannaMonti GiovannaMonti requested a review from a team as a code owner October 30, 2024 16:30
@GiovannaMonti GiovannaMonti changed the title feat(switch): added Switch component feat(Switch): added Switch component Oct 30, 2024
Danielecina
Danielecina previously approved these changes Oct 30, 2024
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Danielecina Danielecina merged commit ca98c05 into main Oct 30, 2024
6 checks passed
@Danielecina Danielecina deleted the add/switch-component branch October 30, 2024 18:00
@Danielecina Danielecina removed the enhancement New feature or request label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new component Switch component Switch component and hooks related activities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants