-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Switch): added Switch component #683
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiovannaMonti
added
enhancement
New feature or request
Switch component
Switch component and hooks related activities
labels
Oct 30, 2024
GiovannaMonti
changed the title
feat(switch): added Switch component
feat(Switch): added Switch component
Oct 30, 2024
Danielecina
reviewed
Oct 30, 2024
Danielecina
previously approved these changes
Oct 30, 2024
fredmaggiowski
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Danielecina
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the Switch component. For now, it is a single component. Once we approve the development of component groups (discussion is in progress on issue #682), we will also create the SwitchGroup component.
[IMPORTANT] PR Checklist
PR conventions
Please make sure your PR complies with the following rules before submitting it.
<type>(<scope>): <subject>
structureAdditional code checks
Based on your changes, some of these checks may not apply. Please make sure to check the relevant items in the list.
index
file