-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Input): fixed Ant props for Ant Design Input #776
base: main
Are you sure you want to change the base?
Conversation
value={inputValue} | ||
onChange={handleChange} | ||
/> | ||
<ConfigProvider theme={scopedAntTheme}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not good to enter the provider here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Danielecina the pr relates this issue:
#775
I agree that the Provider should be used only as a wrapper over the application if possible.
Description
This PR has the goal of updating the Ant theme generated properties to make sure the
Input
component theme does not override the AntInput
component if used in the same App.This fixes some displaying problems, such as an incorrect height of the Ant
Input
component:Before:
After:
Input
Addressed issue
Closes #775
[IMPORTANT] PR Checklist
PR conventions
Please make sure your PR complies with the following rules before submitting it.
PR title follows the
<type>(<scope>): <subject>
structureThe PR has been labeled according to the type of changes (e.g. enhancement, new component, bug).
Additional code checks
Based on your changes, some of these checks may not apply. Please make sure to check the relevant items in the list.
src/index.ts
file