Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Input): fixed Ant props for Ant Design Input #776

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fedepini
Copy link
Contributor

@fedepini fedepini commented Dec 18, 2024

Description

This PR has the goal of updating the Ant theme generated properties to make sure the Input component theme does not override the Ant Input component if used in the same App.

This fixes some displaying problems, such as an incorrect height of the Ant Input component:

Before:

image

After:

image

Input
- updated theme

Addressed issue

Closes #775

[IMPORTANT] PR Checklist

  • I am aware of standards and conventions adopted in this repository, defined in the CONTRIBUTING.md file

PR conventions

Please make sure your PR complies with the following rules before submitting it.

  • PR title follows the <type>(<scope>): <subject> structure

  • The PR has been labeled according to the type of changes (e.g. enhancement, new component, bug).

    NOTE
    Some labels are used to generate release note entries: you can find the complete mapping between PR labels and release note categories here.
    For a more detailed overview of PR labels, please refer to the dedicated CONTRIBUTING section.

Additional code checks

Based on your changes, some of these checks may not apply. Please make sure to check the relevant items in the list.

  • Changes are covered by tests
  • Changes to components are accessible and documented in the Storybook
  • Typings have been updated
  • New components are exported from the src/index.ts file
  • New files include the Apache 2.0 License disclaimer
  • The browser console does not contain errors

@fedepini fedepini added bug Something isn't working Input component Input component and hooks related activities labels Dec 18, 2024
@fedepini fedepini self-assigned this Dec 18, 2024
@fedepini fedepini marked this pull request as ready for review December 20, 2024 11:06
@fedepini fedepini requested a review from a team as a code owner December 20, 2024 11:06
value={inputValue}
onChange={handleChange}
/>
<ConfigProvider theme={scopedAntTheme}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not good to enter the provider here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Danielecina the pr relates this issue:
#775

I agree that the Provider should be used only as a wrapper over the application if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Input component Input component and hooks related activities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input: Design System theme overrides Ant theme properties
4 participants