Show more info in API #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show more information in the plants API, so you don't have to query for every plant and waste a lot of astrobotany's server resources. This could lead to being a privacy issue, as having all the information in one place means someone can easily get the data, when they would have to implement their own parsers and other things to get this data. If this idea isn't wanted because the API would like to be kept the same, I don't mind it having under another API endpoint.
|
Looks fine to me! I'll plan on deploying this sometime tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show more information in the plants API, so you don't have to query for every plant and waste a lot of astrobotany's server resources.
This could lead to being a privacy issue, as having all the information in one place means someone can easily get the data, when they would have to implement their own parsers and other things to get this data.
If this idea isn't wanted because the API would like to be kept the same, I don't mind it having it under another API endpoint.