Skip to content

Commit

Permalink
Squashed commit of the following:
Browse files Browse the repository at this point in the history
commit f534110eaf8df0b2e519c2e69b91365d32d07d0b
Merge: a54d3df19 3f2650a71
Author: Michael Beale <[email protected]>
Date:   Thu Feb 8 10:09:28 2024 -0800

    Merge branch 'master' of https://github.com/michaelbeale-IL/hotcrp

commit a54d3df192a81f199ac9ed8446e5185401153c70
Author: Michael Beale <[email protected]>
Date:   Thu Feb 8 10:08:19 2024 -0800

    Squashed commit of the following:

    commit 3f2650a7104c265b7dc2a76fc96d032178fc4898
    Author: Michael Beale <[email protected]>
    Date:   Mon May 16 16:10:40 2022 -0700

        fixed create account button

    commit f9922bd219a6f2f56ec83931247084a06083dad3
    Author: Michael Beale <[email protected]>
    Date:   Mon May 16 11:32:03 2022 -0700

        removed redirect to Intel password reset.

    commit 9a53bb191e92d976676e56f6e57ca6bbbd0616e1
    Author: Michael Beale <[email protected]>
    Date:   Sat May 14 15:59:31 2022 -0700

        Removed Intel Employee notification.

    commit 8a681e7aad9bd27ece2ac583afc2c184c81097ca
    Merge: e07771553 a0a42d57b
    Author: Michael Beale <[email protected]>
    Date:   Sat May 14 15:49:53 2022 -0700

        Merge branch 'kohler-master'

    commit a0a42d57b035d17591ef7c3b368b972da6731a5e
    Merge: 13ad5aedc fd81deae1
    Author: Michael Beale <[email protected]>
    Date:   Sat May 14 15:48:49 2022 -0700

        Merge branch 'master' of https://github.com/kohler/hotcrp into kohler-master

    commit fd81deae1f20da16fdf3b714e9c81df60f7e577e
    Author: Eddie Kohler <[email protected]>
    Date:   Thu May 12 10:07:16 2022 -0400

        Add api/assign action and use it for several paper columns.

        And add review_types to script.

    commit 78781776f97d0ca7132fbb001db029792a4be2b9
    Author: Eddie Kohler <[email protected]>
    Date:   Wed May 11 22:55:45 2022 -0400

        Canonicalize code for generating revround spans.

    commit 042f7133aff72358f4296d04e920fa5423c10e06
    Author: Eddie Kohler <[email protected]>
    Date:   Wed May 11 22:11:38 2022 -0400

        Review round style: inline-block, left padding.

    commit 534bdd9bebb1a49ea390d9b42424f8501749049a
    Author: Eddie Kohler <[email protected]>
    Date:   Wed May 11 16:09:12 2022 -0400

        Assignment: Support `uid` columns in assignment sets.

    commit ebdd93afbf09b7cccb1060ca00c4cdad3a26355a
    Author: Eddie Kohler <[email protected]>
    Date:   Wed May 11 13:31:41 2022 -0400

        Nits.

    commit f5271cb4c9cc1c8fbf5c154f87b34b0261e2e527
    Author: Eddie Kohler <[email protected]>
    Date:   Wed May 11 13:31:41 2022 -0400

        Remove data-fold-storage-prefix, always fold-storage PC conf/collab.

    commit 58d5c679e1ad2a0ee5d6dfb10e5781da2b9c57ce
    Author: Eddie Kohler <[email protected]>
    Date:   Mon May 9 00:33:40 2022 -0400

        Save collaborators locally even on bulk upload of user info.

    commit e17052894495909af1733c087371d39933718ef6
    Author: Eddie Kohler <[email protected]>
    Date:   Mon May 9 00:31:51 2022 -0400

        Update messages for review saving.

    commit f8f4cb27567b19ee43e6f2596ae7eaddcd463e5f
    Author: Eddie Kohler <[email protected]>
    Date:   Sun May 8 23:36:44 2022 -0400

        Review preferences: Add paper status to display.

    commit bfd08ef764fab84f1b81abb2ed22512ca4611c81
    Author: Eddie Kohler <[email protected]>
    Date:   Sun May 8 23:07:35 2022 -0400

        JsonResult: Use make_error more often.

    commit 446c8ef24d9dda0d8b9b0d109061a12bfbce965b
    Author: Eddie Kohler <[email protected]>
    Date:   Sun May 8 22:02:06 2022 -0400

        Nit.

    commit 6ccb1a835b28eddfc33b6720da1b1847992d970d
    Author: Eddie Kohler <[email protected]>
    Date:   Sun May 8 18:20:04 2022 -0400

        Reduce warning printouts.

    commit b9ffaf06b49905a1b607a965612b1ee9eaf9ffa3
    Author: Eddie Kohler <[email protected]>
    Date:   Sun May 8 18:18:16 2022 -0400

        Derp

    commit 69f47f3062021a27688cc0184aa3fa497404b525
    Author: Eddie Kohler <[email protected]>
    Date:   Sun May 8 14:26:19 2022 -0400

        Add CsvParser::make_json, to translate a JSON object list.

        Only handles objects of scalar values.

    commit b54ac9e9c3421a21ff2f1026e7e86eb10a4b09e0
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Apr 26 11:07:17 2022 -0400

        Dewarn.

    commit 9c2dcd816ab58c60df7a162722a1804e77f0bdca
    Author: Eddie Kohler <[email protected]>
    Date:   Mon May 2 18:59:08 2022 -0400

        Correct decision display.

    commit 0e9ce81a298c60ccfbe588a7d35d3482877e053d
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Apr 29 14:27:47 2022 -0700

        Clean diff_match_patch::diff_mergeEqual_.

    commit c9fa393953b5aa773bc0eab659f10f7e63b1ce8c
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Apr 28 11:59:40 2022 -0400

        Correct a bug in semanticMerge using diff_merge1.

    commit 21c1dd41ab1ed99cacbec4c61bcbd3d9fb3f0907
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Apr 28 11:56:47 2022 -0400

        Add stress test for diff_match_patch based on git history.

    commit 92d998ae428afe2a3909c084a97de15bc8ca5715
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Apr 28 09:28:39 2022 -0400

        Remove obsolete.

    commit 36b3d880d7fdd02d5beeda158935519872d63b7d
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Apr 25 08:10:23 2022 -0400

        Correct histogram bug.

    commit 81b4228b27a3393b673e90a73b9d00483945110a
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Apr 25 09:33:43 2022 -0400

        Countries nits.

    commit cbd39fe7161d398a86b639c7d67394275c7dbf2a
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Apr 22 08:56:11 2022 -0400

        Fix interpolation.

    commit f5161f7c198eca520135e292e9fac5fa3d418773
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Apr 24 22:52:48 2022 -0400

        ReviewDiffInfo checks both myers and histogram diffs.

    commit c0ab1de90b7b2df5b151435ee7a67703eef7ab02
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Apr 24 22:34:54 2022 -0400

        Add histogram diff method.

    commit 92b0a1ada11e82fe9d07e1a07402d2dc04ea7976
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Apr 24 22:32:18 2022 -0400

        Fix potential error in line-mode diff.

        If the line-mode diff merges performed any non-trivial merges,
        there's a risk the array_splice operations would mess up:
        any $out elements past $opos were meaningless, but I think some
        of them might have been returned.

    commit d360bb051ba1d31efd2074ae49923ab15b2a5d1a
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Apr 23 23:32:17 2022 -0400

        diff_match_patch: Add line_diff and line_diff_toUnified.

    commit b899079ff082f7e96a6015fca78005315ad162d8
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Apr 23 21:44:37 2022 -0400

        diff_match_patch: Support \r line endings.

    commit 7eaf8dbfd81b3c1e4468127b4fcf35a74a332944
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Apr 21 22:39:00 2022 -0400

        Admins can add separators to submission forms.

    commit 06c8c25cfb7ed7fbc4bbd4b7eba2888c9c275839
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Apr 21 21:25:06 2022 -0400

        Fixes for stringification of boolean member settings.

    commit 92e21c893bf669cf5e11dd1aac0d582299a6ec75
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Apr 21 21:05:25 2022 -0400

        Update settings UI for submission fields.

    commit b46ddc61319e6e1062bd24381746337d1d315358
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Apr 21 16:52:04 2022 -0400

        Add information to exceptions

    commit df9e79dbfa73be5a8cbef5b82977ef29d54ff0b2
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Apr 20 10:41:29 2022 -0400

        Only one error per renderer type if a renderer fails.

    commit 2ceb82342bc52e222b47a89e01338032e2ddf34a
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Apr 20 10:31:06 2022 -0400

        Nit.

    commit b38c84dbf9bf205b7fe3edb0fb2bb7c3e93ae0b4
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Apr 20 10:24:54 2022 -0400

        Improve otheropt(false) behavior.

    commit f3882ee6908f0faedd8aaf57009bb226ffd45b5d
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Apr 19 21:48:51 2022 -0400

        SearchSplitter: Non-UTF-8 input => no preg_match u flag.

    commit da89e8aec6b8a4059690adf9fa863dac131668de
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Apr 19 15:51:25 2022 -0400

        Add batch/paperjson.php --reviews option.

        And remember that "reviews" in paper JSON is never a paper field.

    commit a6dfbe091fc3bae588450bd0dbb21083dcd734cf
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Apr 19 15:26:08 2022 -0400

        ReviewDiffInfo: Catch exceptions and report them.

    commit 7c5bf07fd354c237db08d2276f9e2ec03a46ecef
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Apr 15 11:37:00 2022 -0400

        Fix.

    commit 9beefe8588117b61af8352a31483a709a9f6809e
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Apr 15 11:11:19 2022 -0400

        Less HTML parsing.

    commit 2e08fb7c7f9f365d9a8fc6c76bd69a4b549b4288
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Apr 15 11:05:41 2022 -0400

        Fix assignment of optional reviews.

    commit 92554aa5ca700c56d9b1b64798b19ad7f3c4551d
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Apr 15 10:43:01 2022 -0400

        Improve Comment_API and error messages around response and comment editing.

        And add some comment-specific tests.

    commit 94f86445c3b28cdac2c15dfb280d83a8dee120df
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Apr 14 09:56:08 2022 -0400

        Improve appearance of New submission button.

    commit d561c90bb8e2411b2216e691338f447d5c9b8f17
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Apr 14 09:41:26 2022 -0400

        Get rid of array().

    commit 70740f7dd385fd62fd376b7c0849e097e7275eed
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Apr 13 21:48:19 2022 -0400

        Emoji-only comment and entry improvements.

        * Show up to 8 emoji suggestions, not hundreds.
        * Backspace doesn't change behavior of Enter if suggestion is
          highlighted.
        * Fix emoji regex.
        * Fix line height of emoji-only comment.
        * Entry for :skin-tone-N: is automatically reordered.

    commit 0bb3a4edce96308b3c028e93a939d84c0aef7c22
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Apr 13 10:43:52 2022 -0400

        Emoji-only comments appear larger.

        Also change the way skintones are entered.
        Type `:+1-` to get skin tone completion.

    commit 2d3d99e0a0420368497604c5ace002f4c74a4bff
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Apr 12 21:36:40 2022 -0400

        Update emojicodes.

        * Unicode 14.0 emoji.
        * Add skin-tone-N patches.
        * Add `updateemojicodes -r`, which returns a regexp for emoji.

    commit dd7b367e2ddb581b1d66f9ac1b4dc72da10f1164
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Apr 11 12:24:15 2022 -0400

        Prefer cast as binary to like binary.

    commit bc3579da936871eb5064c68579945b09b46a4859
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Apr 11 12:20:10 2022 -0400

        Mention checks.

    commit a693d1a42bb261752ae6fc24bddf6d7df5fea6dc
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Apr 11 09:20:00 2022 -0400

        Nits.

    commit 4dc07e79120a42193d0ea2c99564451b8fb7c962
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Apr 11 09:19:45 2022 -0400

        Add some more help rows to Search keywords help.

    commit 8f58e60e9f4fa601cb3b3f1e384bff629f4d5ba8
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Apr 11 09:14:12 2022 -0400

        Idiot

    commit 535cfac305926d80f361ccec7e372a669985f8b0
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Apr 11 09:02:48 2022 -0400

        Add `re:notaccepted` review search.

    commit dce35177b0daff4913036b8eeb92116fa4bd4044
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Apr 7 21:51:52 2022 -0400

        SettingValues::search_enumeration_id is specialized.

    commit 6e414ea6061b8bad569d3ca91de07fe51fcb4675
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Apr 7 21:19:19 2022 -0400

        Move SettingInfoSet into its own file.

    commit 21219e41994473141f963f77aa3219c70c3d6ba2
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Apr 7 11:10:54 2022 -0400

        Fix actual problems found by unused-variable checking.

    commit a98a5e047ba4ffd5d8d3bfc02c89c3982f6ef95f
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Apr 7 11:09:59 2022 -0400

        Fix non-problems found by unused-variable checking.

    commit bf75c281fff4d21841a20eab85413233aa830a51
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Apr 6 14:14:45 2022 -0400

        Settings: Groups list the settings the reference.

        This is better than settings listing the groups they include
        because:

        * More natural way to include a setting on multiple pages
        * One step toward a search page that includes just a few matching
          settings
        * Easier to change page locations; edit just settinggroups.json

    commit dcd3ed81c348ff619ee8f4325d038b2fe3f91415
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Apr 5 21:37:31 2022 -0400

        Settings updates, mostly internal.

        * Update names for format-checker settings.
        * Make decision__category readable.
        * Rename print_section methods for clarity.
        * Let Si::$group inhert from parent.
        * Setting groups record included settings.

    commit c5c81212b3d535af5740ee7298cc64afce968c01
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Apr 5 18:20:05 2022 -0400

        Fix seedec_showau setting

    commit 91d559318b9ef12015845cad1b23769dfeb7a868
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Apr 5 17:56:52 2022 -0400

        Add a hashid for track settings.

    commit cac9ae849e466de001f7c37f96f49b4b1df05a32
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Apr 5 15:51:07 2022 -0400

        Optimize 'conflict:A OR conflict:B OR conflict:C' searches.

    commit 6c23d607e8a824f2d870b92df4bf41b8f6ff36dc
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Apr 5 15:22:21 2022 -0400

        Rearrange search term construction to avoid table limits.

    commit 93fe96ef5f70629f6fede3cade6b763496b38a6f
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Apr 4 13:03:14 2022 -0400

        JSON settings milestone: Add tests for JSON settings.

    commit f469796b727df796b9815fc1c8ae4a95f900cb12
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Apr 4 09:57:39 2022 -0400

        Start work on JSON settings batch script.

    commit bf0abba37e7de9b3d1e1a217d94b9a764b02b9f9
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Apr 3 23:07:59 2022 -0400

        Start work on JSON settings.

    commit 0d9498f5fae63b38e39960964cbc03b8a4f66846
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Apr 3 16:37:29 2022 -0400

        Massively faster PHP-level JSON parser.

        * Not tons of substr operations; use positions.
        * And handle surrogate pair escapes correctly.
        * And switch API from `decode_landmarks` to `decode_positions`.
        * And add `path_landmark`: path_landmark("a.b.c") returns the
          landmark of the object at path `.a.b.c` in the input.

    commit ff753b919237dad46fbd312ebc0a65cbe31da010
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Apr 3 13:26:31 2022 -0400

        Rename review-field JSON: option_letter => start.

    commit 7060ce7d4aec0a0f408eaaf5f76fd3d5abb36345
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Apr 3 11:27:05 2022 -0400

        Singularize setting lists.

    commit e5d5ddae52d8ea62c49b0f424d9e71ed488fa662
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Apr 3 11:25:33 2022 -0400

        Setting links: Differentiate use cases into different functions.

        This allows for better errors.
        * setting_link is for a setting.
        * change_setting_link is for a “Change this setting” link.
        * setting_group_link is for a setting group.

    commit 0f1e71595afe7411a2321b3b22394d377963c6d8
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Apr 3 09:44:56 2022 -0400

        Rename topic__newlist to new_topics.

    commit 3cb396e44a25e4b08b9d4bc2195301307cc04d09
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Apr 3 09:33:28 2022 -0400

        SettingValues: Handle aliases explicitly in request.

        If request contains a string corresponding to an alias, copy that
        string into the reference.

    commit da33806a697347ddde6e2c42459af5d9f20efd0d
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Apr 3 09:31:34 2022 -0400

        Update copy-topics JS handler.

    commit 72ec35f459673a96e7c1b49b3bf3f09bddc6330c
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Apr 3 08:55:36 2022 -0400

        Add QrequestFile type.

    commit 09144af50872406796c17d8ba091fb025b1112ef
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 31 17:31:35 2022 -0400

        Rename method.

    commit fec08d7d58fcb71fa39a667810b3f6b0095a3a53
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 30 14:33:49 2022 -0400

        Nits.

    commit 9507fbe73847a4d29e47e7570f3cb35a42e3a0d9
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 31 08:56:30 2022 -0400

        Fix a message format.

    commit 3355133b5b4999caa8f5ecde5d4f94c70d1e117c
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 31 08:55:30 2022 -0400

        Metareviewers must follow VIEWREVID track permission.

    commit bb5eca8a0970a34a24f7ab9b2ca41b683c6a2ecd
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Mar 29 17:53:16 2022 -0400

        Name button better

    commit 59b7e0ede7f963c798b51c9ad20a2818472c4838
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Mar 29 13:41:11 2022 -0400

        Mininit.

    commit a7df8713931e950894927713acd4170525bd12a3
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Mar 29 09:23:13 2022 -0400

        Allow PC to bulk-download accepted papers.

    commit 7f5288ea380c43351ab7f42475456d8e9ef3dad0
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Mar 29 09:21:08 2022 -0400

        Fix Ht::select.

    commit cd3c64a9a4576d1dcecd40bea848e850a1d765dd
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Mar 29 09:13:15 2022 -0400

        Allow user to define a bulk-download warning.

        And extend logic for overriding $Opt[] with settings to booleans.
        And rename option to pcWarnBulkDownload.

    commit 5355c425421b7acdceda0e43fc671aded8e6d21d
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Mar 29 00:01:45 2022 -0400

        Warn about PC bulk downloads when option warnPCBulkDownloads is set.

    commit 07968de63e16925a176e3cfc5bfc536bc829773a
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Mar 25 15:37:08 2022 -0400

        Improve display of score fields with only one option.

    commit 22088c6a5f3ed481661928a446bc7c2ca1e3ff31
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 24 22:37:33 2022 -0400

        Update backupdb script.

    commit 5aa779ae4949d6266d7f64562ffffc051595e425
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 24 19:10:32 2022 -0400

        Remove unneeded.

    commit 05599e15dfac96753233b8e000f8a5a76100b2be
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 24 15:15:21 2022 -0400

        Whoops.

    commit 39a8638ed0f67210e3a3c4b73eb30abc735e15f4
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 24 15:13:34 2022 -0400

        Start computing review diffs (but don't store them).

        Complain to a file in /tmp if diff_match_patch fails.

    commit 857b14123a893be05c12a7f086417ebe0a0fc687
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 24 14:05:02 2022 -0400

        Add HCDelta functions.

    commit 70829124ec7f04fade786cfd6d594d4e87ed57f0
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 24 13:33:42 2022 -0400

        diff_match_patch: Rename, use namespace, separate tests.

    commit dea1c504944a20e4f4eeaff60bde49209386bc51
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Mar 22 13:20:31 2022 -0400

        Timestamp column only considers timeSubmitted.

    commit d3f650a077b42eab2a9b526b0cf12ed4b1fa2c69
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Mar 22 13:20:19 2022 -0400

        Dewarn.

    commit fe51503abd4e5f48331aa0d54df78fbd46f03f8f
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 24 11:21:04 2022 -0400

        Add all tests from diff-match-patch.

        * Generate UTF16-compatible deltas.
        * Fix URL encoding.

    commit 20766dd0130563c93c05347deb851c76f340ba53
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 23 13:44:11 2022 -0400

        Add a partial port of Neil Fraser's google/diff-match-patch.

    commit ed24960dda450023ce804e30ade792f4a876359b
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Mar 21 10:49:15 2022 -0400

        Reduce reliance on text-decoration-line.

        Edge 18, which who cares but some people still use, does not
        understand text-decoration-line; so in most cases do not use it.
        It is still useful when NOT overriding long properties is important,
        which is only on paper titles I think.

    commit 94dc937fa2c7e6060cd6943d54251aa07a4ce289
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Mar 21 11:12:05 2022 -0400

        Looks like only window.focus() is now required.

    commit 3ebfc9381be293156c9cc7a5f8fde96421e42a90
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Mar 20 22:59:03 2022 -0400

        Internal: Update ScoreInfo API.

    commit c6feed43f3d0c02fcbfda4a083ccf556e7759f08
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 19 23:11:16 2022 -0400

        Nit.

    commit 250cb7eb00915063a46d2b4514d2e695c0da614f
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 19 22:47:03 2022 -0400

        Recover offline-form choices for score fields.

    commit b2c6d01a4fbd82f67b029e7c768a404ba077b57f
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 19 21:35:38 2022 -0400

        Wrap displayed mails.

    commit 273ee8b1d9c7a454b735c22b6479cd6aeddfd5a4
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 19 18:12:37 2022 -0400

        Nit

    commit 8340b9fee12756ea831ed5e4be9fe77442fb1f23
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 19 18:02:36 2022 -0400

        Store contactdb roles in database, not session.

        And update session format to ensure database names are distinguished
        from other keys: prefix database names with @.

    commit 1b08d0409ad0ae73d4033e7af4e0851dcf7b1cd2
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 19 17:24:23 2022 -0400

        Schema update: Review fields stored with short_id.

        * And they're 16 bits, not 8.
        * And add cdbRoles.
        * And remove reviewFormat.

    commit 1a06eb0847ea753ccb1eb66b41d54f7f80ab77ee
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 19 16:34:35 2022 -0400

        Improve review CSS coding.

    commit 989a42ecf541312af3d4867f21bc6c618a37de36
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 19 15:53:10 2022 -0400

        Standardize on ReviewField::$short_id.

    commit 854f3e2e1a1f774fd243f2287a5a9c3b769f8517
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 19 13:48:07 2022 -0400

        Schema updater must not depend on current classes/functions.

    commit af3e46001c0717b7de52a03dac1c654c6bf44141
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 19 13:49:02 2022 -0400

        File rename: src/reviewform.php.

        And standardize on "Comments for authors" for the initial name of that
        review field.
        And some nits.

    commit f7462d26dec6c3cd017ceebc79d37eb800494b9c
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Mar 18 16:31:30 2022 -0400

        Fix double appearance of profile save errors.

    commit a108f3dad123e28cbf3f4c794581b52d83122da6
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Mar 18 09:24:37 2022 -0400

        Attempt to capture more information about JSON errors.

    commit 4a7d7e3a53f0ed2d5498d22e726d30768861bbdd
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Mar 18 08:32:03 2022 -0400

        Regain editing of final-version-only documents.

        Fixes #270.

    commit 50f0993bc3fc49c2bdd0f52714a061eefa2e0184
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 17 21:53:56 2022 -0400

        Internal: Caller must call initialize_conf().

        And use dbname as a key to $_SESSION, not dsn.

    commit 889fb33762152ea62513de70a063df9428cc1a4f
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 17 18:00:12 2022 -0400

        Sessions: Expect unique dbName; dsn is too much.

    commit 9a245a9cc0b258de994618a2461ba0caccc2f8ff
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 17 16:15:30 2022 -0400

        Nit

    commit 9ba2fcae05e6c17fb13bd84dd62f90f2e2a96c96
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 17 16:13:46 2022 -0400

        Move ReviewField into its own file.

    commit a1aee376ef22d35a431bdfed71806a852be14344
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 17 16:00:30 2022 -0400

        Nit

    commit 62279e54dedf2857ffe37fc7f61c376898c0c0b9
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 17 15:48:16 2022 -0400

        Recover format preview for review fields.

    commit 2a82b2631456dd80b3f9a4d90a02d68e7668bfba
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 17 14:18:49 2022 -0400

        Update batch scripts to use new style.

    commit d9a6fadba1ba422c15a4d4a0284d3dbc75688277
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 17 09:54:38 2022 -0400

        Remove unused.

    commit cde12c9377b6568d3ad3d7fb7e6ae32e58b86c56
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 17 09:09:25 2022 -0400

        Improve database connection protocol.

    commit 7284ccba6f02f383d33136e25085f72fa5399fe7
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 17 07:56:29 2022 -0400

        Nits.

    commit 2b754ff1f42e79f386b7b431e9557563d0fb7877
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 16 23:26:13 2022 -0400

        Add beginnings of PHP-based backup script.

    commit cbd6cd925f727b0f1790ac1b3edff7a824c45b4e
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 16 20:20:07 2022 -0400

        What the hell

    commit a0c9b6ac85a922414cfdbdea9b4f24f5d0b93cd0
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 16 18:59:14 2022 -0400

        Introduce Text_ReviewField.

    commit 6d6ea54c066d2ff9906c57f3e081e6a6b42654c5
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 16 17:26:50 2022 -0400

        Start preparing for multiple kinds of ReviewField.

        Introduce Score_ReviewField.

    commit 65f6da9304d3eed59ffe1323a473af078d6fe408
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 16 13:57:53 2022 -0400

        Tracker lists use `.url` component, not `.urlbase`.

        This might be a mistake, but it is easier to go with that mistake
        and add support for `.url` components than to fix it.

    commit 1ade83e1e3cd6592668e3a9fe492361643d9f843
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 16 12:25:58 2022 -0400

        Improve tracker display: adjust left-hand nav top position.

    commit b77e9c643f7970154e63910142a7386575686f0c
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 16 12:25:44 2022 -0400

        Fix long-standing Safari display issue.

    commit d1eb037290f25cddb4bff2f03ac970f1c006332d
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Mar 14 23:57:14 2022 -0400

        Support automatic redirection to a /u/NNN that can view the paper.

    commit 926bc3a57b060a06b45648ec22f319c2432311dd
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Mar 14 23:56:43 2022 -0400

        Nits.

    commit 25b15f482ac27ad6acb86e1f8947b8811956af01
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Mar 14 22:12:03 2022 -0400

        New style for batch/saveusers.php.

    commit a4866ed90afffb5bb867878da49f4ab7333be4a3
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Mar 14 15:18:25 2022 -0400

        Getopt gains types, cleandocstore follows new pattern.

    commit 415bfb74d8e55abccf00f568b9159a95c95ee2db
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Mar 14 10:10:24 2022 -0400

        Internal: New pattern for batch scripts.

    commit 952ceeeb94fa246319d33e7c4f0b9a0e38089d32
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Mar 13 17:57:31 2022 -0400

        Add WordCount_PaperColumn

    commit e0777155394db43ccb5811c79c3a4cb2d35a19cf
    Author: Michael Beale <[email protected]>
    Date:   Sat Mar 12 17:49:46 2022 -0800

        undoing changes.

    commit 7169d9e4ff598dfb11cd8536a4482aa303c59759
    Author: Michael Beale <[email protected]>
    Date:   Sat Mar 12 17:47:36 2022 -0800

        z

    commit 2c40d866fe7f7eafb903219966b417953398266d
    Author: Michael Beale <[email protected]>
    Date:   Sat Mar 12 17:46:16 2022 -0800

        x

    commit 00abe89304fa1f4dd776aab42af18a9be10e3fae
    Author: Michael Beale <[email protected]>
    Date:   Sat Mar 12 17:42:22 2022 -0800

        trying something

    commit f36de298b5a865c627b828b2207afc468e6d106b
    Author: Michael Beale <[email protected]>
    Date:   Sat Mar 12 17:37:02 2022 -0800

        Hack #1

    commit 56feab6abfe6db364aab0200bcd64487e29a6ee4
    Author: Michael Beale <[email protected]>
    Date:   Sat Mar 12 17:35:16 2022 -0800

        trying to pass name from LDAP

    commit 18ef145acb3b310a77d02d19d9feb346168e7302
    Author: Michael Beale <[email protected]>
    Date:   Sat Mar 12 17:31:04 2022 -0800

        re-enable login

    commit b861f7cbc32eb1565b268b4b67e3030dc2c92d8e
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 12 16:12:29 2022 -0500

        Banal parsing: support word limit

    commit 6eed51fee01ef2314ff861f9b078c17133cbc766
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 12 15:55:59 2022 -0500

        Too-few-body-pages warning: don't show if >=10 body pages.

    commit 1ae55cd187830dd7c42c626e6668c1a063bc3860
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 12 15:51:36 2022 -0500

        Make all hr.form-sep explicit.

    commit 7352c6fad24159dac1218877eb6b955cc98142d6
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 12 15:13:35 2022 -0500

        If appendices go up to I, don't pretend we're back in the body.

    commit 55fca04de60414f260b55b3ae32b4d96cf64857b
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 12 15:02:09 2022 -0500

        Teach banal that Appendices is OK English.

    commit 208f16db0d6a6f964f163bb5da99085f1350118e
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 12 14:52:29 2022 -0500

        Rely on PaperSearch for type selector names.

    commit d0e46a34fdd15cff2677d9fe464bb0f3c0d6464d
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 12 13:05:22 2022 -0500

        Don't report absent-submission warning on new submission.

    commit eafdd55c32dd52fae8f02a092f561622b35d4548
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 12 13:05:41 2022 -0500

        Appearance of "New submission" link on home page.

    commit 460b20f3b2c353a985a254c4246af75b16a1eec8
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 12 13:01:21 2022 -0500

        Recover decoration of nav menu with error & warning state.

    commit 29a849def860be47693cec504b4b8c439f0a8c5c
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 12 13:00:25 2022 -0500

        Improve "Updated submission" message.

        "Updated submission Submission" is too weird to take.

    commit 1c33ee083ced6f671d0d4fd861cb116e18cd4b5c
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 12 08:53:04 2022 -0500

        When leaving a comment if multiply-logged in, advertise who you are.

    commit 4715dddd2839eef58ce25805c455be7558c65aaf
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 12 01:17:31 2022 -0500

        Add show:wordcount column.

        * Background format checks privilege things on or near the screen.
        * Correct document loading in DocumentInfo::npages/nwords: Let
          CheckFormat decide whether to load the document (otherwise we
          might load EVERY document even if CheckFormat would delay).

    commit 310fceefd6a0f27a5dd01ae17fad49305e92c46f
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 12 00:12:32 2022 -0500

        Add support for counting words in PDFs and adding them to banal.

        Mike Swift request.

    commit 23bbdce87a88c48935d893d12505c464be1edea3
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Mar 11 21:08:26 2022 -0500

        Add a shepherd setting, update settinggroups, add print_separator.

    commit e4de7c92f2c51300fe3382a6137071d481c3e38f
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Mar 11 20:49:52 2022 -0500

        Prefer hr.form-sep to div.form-g.

        Unnecessary hierarchy is a problem for our extension plan.

    commit 4a2752c18444d97b3dc636561f732a99e9d4c51d
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Mar 11 11:32:28 2022 -0500

        Review permissions fixes.

        * Review rounds affect deadlines, so load them in myReviewPerms.
        * Add Contact::can_edit_some_review for editing reviews in general
          (existing, if any, or new).
        * Add Contact::can_create_review (subsumes can_create_review_from).
        * Make Contact::can_edit_review *require* a ReviewInfo.
        * Clean up permissions errors for these functions.

    commit 4070d0714398d08a2243fadde886655040a2deb3
    Author: Michael Beale <[email protected]>
    Date:   Fri Mar 11 07:52:15 2022 -0800

        logging name to see if it's working.

    commit 9ca6998385ce4700426c484a3828b8fcc603bfc0
    Author: Michael Beale <[email protected]>
    Date:   Fri Mar 11 07:49:45 2022 -0800

        fixing name

    commit 241b00e653f640227aadca9687b76fe2afa0fb72
    Merge: 881c5c644 13ad5aedc
    Author: Michael Beale <[email protected]>
    Date:   Fri Mar 11 07:42:06 2022 -0800

        Merge branch 'kohler-master'

    commit 13ad5aedcc1d21c67758c03d14445bb05696aa67
    Merge: 881c5c644 b95acbac5
    Author: Michael Beale <[email protected]>
    Date:   Fri Mar 11 07:40:16 2022 -0800

        Merge branch 'master' of https://github.com/kohler/hotcrp into kohler-master

    commit b95acbac5e52cd3d053a64b798f33be05f94a09d
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 10 20:47:08 2022 -0500

        Simplify ComponentSet sectioning API.

    commit 881c5c64432ca6bbf7c6da0c7bbe6cfaea4cf2b0
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 15:43:37 2022 -0800

        log message

    commit bea54777b8469a9bb4cc60caed1037edb8aa18b4
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 15:42:29 2022 -0800

        fixed array indexes

    commit dcae1fafa36a1f3cb0f3270940306c4c162b1bc7
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 15:41:10 2022 -0800

        read search filter from config.

    commit 277d3809e270ab67d2548d47b2fb0f5ada399c03
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 15:37:50 2022 -0800

        changed message

    commit 08f3e2ebc84975c52c3b2d250d4592e598a78426
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 15:36:44 2022 -0800

        fixed regex to only look for the filter

    commit 95b82ceee4a5b36e796866943b2e4ea5e8f03672
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 15:28:19 2022 -0800

        fixing message

    commit c7a791072f7e117976794d2d6ed29ef21da66f15
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 15:25:57 2022 -0800

        fix log message

    commit f90ea2e8d8e783fcdbe6c5b49f01045705b7509a
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 15:22:56 2022 -0800

        moving LDAP filter to config.

    commit b3154444721597683e498e2f1c9b159ada2d169c
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 14:14:36 2022 -0800

        can this actually work now!?

    commit d2f0d5d2fc0363c4665ca60847cc3f10e8a760ea
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 14:01:26 2022 -0800

        more config changes.

    commit 4c3a6581dcc929f883e8426d5302a6ca7bce97ec
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 13:53:57 2022 -0800

        moved initial Bind user name and password to settings

    commit 4fd5778287208415fa8959068063e544c251b997
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 13:47:22 2022 -0800

        trying anonymous bind for initial search

    commit 54c2106553f406588d4421f47a0d2837fe43a50a
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 13:44:09 2022 -0800

        trying w/out initial bind

    commit 8ddcc154e3447e31cf4085444440f385a7c72c08
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 10 16:28:13 2022 -0500

        Fix bug where we were calling hotcrp.add_comment(null).

        This was a divergence between time_review_open() and time_review().

    commit 59658be380b9e280041e642674cf3f8411f00798
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 13:08:33 2022 -0800

        remove pwd

    commit bf376da793b1ddc5b9a6a050375950e32b890bf7
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 13:04:26 2022 -0800

        add password check.

    commit 5b7adf16bf6f2df95ace79654ad8655bbcf2b3d3
    Author: Michael Beale <[email protected]>
    Date:   Thu Mar 10 13:02:37 2022 -0800

        log DN

    commit bd0e1781d6a16e5477613e438b4860a3ed5ab517
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 10 12:17:15 2022 -0500

        Don't prompt with external reviewers' names if they can't see comments.

    commit b73f37c515676ecfc769db42fb5a9684c41b56a5
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 10 07:57:52 2022 -0500

        Fix usage of Dbl::escape_like.

        Output of escape_like (old sqlq_for_like) must be escaped again before
        being passed to MySQL.

    commit 9b91b6e50bc5bfc7a3cb813e13f6dffa4d0374a9
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 10 07:21:17 2022 -0500

        Emphasize that this LIKE is binary.

    commit e1e912def40c8e7b605707180ae3f0eb6845da5c
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 9 22:35:45 2022 -0500

        Affiliation searches allow words in place of spaces.

    commit 5759898250a4ef377377843cfe5060466380b032
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 9 22:15:35 2022 -0500

        Add affiliations to unaccentedName.

        unaccentedName in the database is now db_searchable_name(): an all-
        lower-case, deaccented text that includes first + last names and
        affiliation.

    commit f3446cc0f8f2da1cd56b23a69f416babba4720a6
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 9 22:14:38 2022 -0500

        Correct schema updater for past versions.

    commit 71d735f3d8c1b1b8f9f3144a8cbfbe302315f19c
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 9 20:50:49 2022 -0500

        Recover highlighting of field matches on paper lists.

    commit fafc31bed1df1d861ce134babe87bf0de65c914c
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 9 20:50:38 2022 -0500

        Search page: Managers can override conflicts.

    commit d4c8a3a4d4363dab38db634366baafa88e6fd1fe
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 9 20:27:12 2022 -0500

        Allow track administrators to override conflicts.

        Contact already knows how to turn off the conflict override.

    commit cc8df261c8788a2dfbd5c13ef56c447d34173cdc
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 9 08:33:46 2022 -0500

        Rewrite comment visibility and permission functions.

        * Authors can exchange comments with reviewers when any comments
          are visible, as well as reviews. That way comments about the
          submission can lead to exchanges.

        * Now the ability to save a comment might depend on its topic,
          which requires API changes since topics can change.

    commit f242358c983a8ea09b198fef3f80f227e3831516
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Mar 8 13:31:30 2022 -0500

        More message-related visual improvements.

    commit d875b44ec1aa69c23592ebc03f4c87817c38d4af
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Mar 8 09:46:59 2022 -0500

        Hopefully fix bug where author-view state != author-view checkbox

        on preferences page.

    commit 8f1ea954384f299455129471182aff9b56cd5feb
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Mar 8 09:26:45 2022 -0500

        Style updates, especially for messages.

    commit 3d5ef4bdacf5308c8f5517a79189fb8fde084e56
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Mar 8 08:16:33 2022 -0500

        Correct ftext.

    commit 7c851265ee9b6f154abbf7d2bc3d8ab910d00565
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Mar 8 08:16:24 2022 -0500

        Having swept out obsolete styles, remove warning.

    commit a63c67be45a610b388881699e5089129ba841769
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Mar 7 12:03:07 2022 -0500

        Support DKIM mail signatures with DKIMSigner.

        Provide $Opt["dkimConfig"], which should be a JSON string or PHP
        array with this structure:

          {
            "key": "file:///path/to/private/key/file",  /* or PEM string */
            "domain": "domain.com",
            "selector": "selector"
          }

    commit 11209ee6c23a03fb144ff5d311f983a11bf21fe7
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Mar 7 09:18:29 2022 -0500

        Move MailPreparation and MimeText to their own files.

    commit 051f3786b5b796ef9397846aa2ed9491158bdc57
    Author: Adam Doupe <[email protected]>
    Date:   Thu Feb 3 21:57:37 2022 -0800

        Prevent uploading an offline review from showing "Submit Review" buttons

        Add the `ignore-diff` class to the offline reviewing form submission so that the "Submit Review" buttons do not appear after a file is chosen.

        Fixes #265.

    commit 7e69ec6d46085eeff37907acaa30c3285acaa037
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Mar 6 23:38:04 2022 -0500

        Option spelling improvement.

    commit 92a2c5cd509cc755e44c238ebb73d2a0fe8a1ffd
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Mar 6 23:36:31 2022 -0500

        More message and appearance improvements.

    commit 5d68f00699c3cedb49a6f63b66d3dea10a82d886
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Mar 6 23:32:48 2022 -0500

        Report when saving a comment if authors were notified.

        And improve reporting of notifications for admin updates, such as
        editing a paper.

    commit ba576aaec128806b52ee4d1cd3715d9e0a0f7a55
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Mar 6 23:29:29 2022 -0500

        Styles: Use double arrows, not thick arrows, for strong topic interest.

        And improve topics paper column: semicolon separators, not space.

    commit eac28d538ab3a5411b8519b1657aa0d1a32ff4fc
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Mar 6 23:27:15 2022 -0500

        Add `force index` to complex queries.

        Newer MariaDBs do not always use a primary index even when obvs
        they should.

    commit 27c594e45905eacf2c7642edaab26a0c78bda130
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Mar 6 12:33:10 2022 -0500

        Report changed fields when updating a paper.

    commit 5baf589b4c354b83d3577b2074e78ef5830e63b0
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Mar 6 12:14:41 2022 -0500

        Update interface to marking paper-save changes.

        Accept an option, not a string.

    commit 1fd28118e72514f697592c45b06abf7f4a4346b3
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Mar 6 09:28:35 2022 -0500

        Improve paper-save messages and improve message appearance.

        * Set max-width on messages.
        * Center some messages.
        * Delay rendering of some messages.
        * Add Ftext::concat and Ftext::join.

    commit 50da7075c90657912805bc36994c63f871eae8c7
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 5 15:52:37 2022 -0500

        Little fixes to last commit.

    commit d429b4d01a63a3e0f291832fdd2eb51c668a2270
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Mar 5 15:52:37 2022 -0500

        Session list ID compression improvement.

    commit 0625afcfa3c90e199c6930f417f25479891c094a
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Mar 4 15:44:47 2022 -0500

        Fix tests?

    commit ca2850d4545b06c265be6dc165637ecae553674f
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Mar 4 15:41:02 2022 -0500

        Fix compares of strings and ints.

    commit c764f0a39966bd5deb44a56129c130a616c22bce
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Mar 4 15:36:46 2022 -0500

        Verboser no-choices-match option search error.

    commit 609e610dbce3d5bce13a9256ea40617bbf4e2877
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Mar 4 15:28:40 2022 -0500

        Handle fold/unfold events through handle_ui.

        This allows setting priority, which makes the UX for submission
        fields nicer.

    commit db2ce50f173b8bee05035f57850d3190d08e4a4e
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 3 17:09:40 2022 -0500

        Allow defining field conditions for newly-added or newly-renamed fields.

        And add a test for said capability.

    commit ca56e298c6b747a4bf53c7df459103cfa0328f47
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 3 17:08:37 2022 -0500

        Don't use Error exception type in PHP, that's internal use.

    commit 6c31fab879f36f3d5fcb922f2e27c6e3c44eb6b7
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 3 15:56:29 2022 -0500

        Add settings UI improvements for response names.

    commit 69b2ffe80a0710c6aa8029938a6375dbe367298b
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 3 13:27:24 2022 -0500

        Response settings UI: Show number of responses per round.

    commit a036a76a229a9a4d0fd31823246465ebbf6301a9
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 3 13:24:59 2022 -0500

        Fix response-round bug.

        Fucking case syntax idiot.

    commit 3d9e0dfcc499e502284a5f3b91b15aa509ad1cf2
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 3 13:23:16 2022 -0500

        Add test that adding unnamed response round renumbers responses.

        This test fails currently.

    commit d68f69cc30dd45808c442381f2e827628dff3a62
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Mar 3 13:09:01 2022 -0500

        Add test for response round settings.

        * Rename resp_round to response_round.
        * Add invariant that all responses have author visibility.

    commit 400302e6937f8c8c3ff41038a19a882cf863c822
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 2 23:20:56 2022 -0500

        Remember whether collaborators are folded; allow folding PC conflicts.

    commit 58ea281190847247a6e80399d587c3148a1787ae
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 2 22:30:05 2022 -0500

        Styles: Horizontally scroll review table.

    commit 063ec5b699260bfa709d937c902010c5b080b163
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 2 22:28:31 2022 -0500

        PaperTable: types, fold when editing.

    commit 0b3692df8f98ba4a7fb310711339ae69e7a61cb4
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 2 22:26:46 2022 -0500

        Script: Add append polyfill, fix replaceChildren polyfill.

    commit f2f81f0d333df557deef230efa4ae45eac4e8f1e
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 2 13:20:07 2022 -0500

        Regain conflict-of-interest error message.

        *All* message overrides must be applied at once.

    commit 6e8c464e3876f99bb35c4abcaa7328ebdf8e0c79
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Mar 2 13:40:47 2022 -0500

        Add test of field descriptions that fails.

    commit 103ba6334943f79d51cd1354f879fa234a8b693d
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Mar 1 18:17:40 2022 -0500

        Style tweak

    commit f09bdac59e96ad1225fdb58eff6934d831cf8b0c
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Mar 1 10:55:14 2022 -0500

        Comment representation and appearance, navigation sidebar API.

        * navsidebar.set order of arguments.
        * navsidebar.merge lets multiple observable elements share the same
          sidebar item.
        * Use this so that sidebar doesn't depend on a group-of-comments div.
        * Render all comments as top-level children.
        * Update styles of feedback messages.
        * Simplify spacing.
        * Show heading when editing a comment.

    commit 7aef56cb6e23147f74656713a12d0f6a2201377d
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Feb 28 11:46:06 2022 -0500

        Fix upload API on comment attachments for new comments.

    commit a2f1f8bd3b0e9b2ac0d207e19950f738982ecd8e
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Feb 28 11:40:28 2022 -0500

        Correct wrong hint: comments about submission were SHOWN to authors.

    commit 11b17a1237da150abddf06a6e1f5d700da2fb3a1
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Feb 26 16:46:29 2022 -0500

        Maybe fix a bug in nextprev_shortcut.

    commit 513adb9a869c58a1e134ca9685ab1241986db56c
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Feb 26 08:30:01 2022 -0500

        Revert part of 0a834778: str_ends_with not accessible here.

    commit f532bddb46083611ab09b4a634a915ddc6ac7904
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Feb 25 23:36:14 2022 -0500

        Procrastination graph can be clicked.

    commit 3b6a4993226248afb9f0dfc5dd2e299d5ffe280a
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Feb 25 23:16:35 2022 -0500

        Fix crash with certain inferred indexes in formulas.

    commit fa8c45d954fd7967594bfbac5cf671605bf1feef
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Feb 25 09:12:55 2022 -0500

        Improvements to Navigation with .php suffixes.

    commit 0a8347780ba9c6028611ec87599b95941f7bdf6b
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Feb 25 09:12:38 2022 -0500

        Fix behavior when a review deadline isn't set.

        Reported by Juan Altmayer Pizzorno.

    commit 2d8c7a2508773001e786756535db778c68789061
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Feb 25 09:11:25 2022 -0500

        Improve warnings on unexpanded keywords.

        * Ftext.
        * New-style HTML.

    commit dab3a90bfe8076dc68849da441e24067ed304853
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Feb 25 08:07:16 2022 -0500

        Remove unused.

    commit d8adf11899826099a1e3b4585b9a572e0b7669b8
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 24 15:38:22 2022 -0500

        Smart punctuation for mention completion.

    commit 6b735215d52908e3c7ff5939f15ac1a878694534
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 24 14:41:23 2022 -0500

        Nits.

    commit 3353047a80a560d9e6d9202e41c788ea2332450f
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 24 14:41:17 2022 -0500

        Nit: Don't mention self.

    commit 51877cde90e1eda70adc78c01a0ff0e0842317f3
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 24 14:40:03 2022 -0500

        Fix deanonymization of reviewers to other reviewers via mentions.

        Sometimes *only* the reviewers can see the paper; so you shouldn't
        mention a PC member who is in that situation separately from their
        identity as a reviewer.

    commit 45351d6384fc9f1f83df43b0368844e9f9c1b966
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Feb 22 18:52:43 2022 -0500

        Types, test nits.

    commit e91ab72c6bf8b64087d743122b1d1280ea3fce3b
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Feb 21 10:41:10 2022 -0500

        Internals of groups_by_paper_id improved.

    commit 92af7a38a047b46f77b69960e96e46b389992472
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Feb 21 10:39:39 2022 -0500

        Test improvements, dewarns.

    commit d3ce2e9104217ee2c09fb11f6519f08d6e5056aa
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Feb 20 23:42:21 2022 -0500

        Fix home-page `re:proposal` search.

        * Link to assign?q=XXX not p=XXX, because p=XXX no longer works.
        * Fix multiple highlight colors.

    commit 84e05c14e987591a277563bf7e4f22d7c24b484c
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Feb 18 23:56:07 2022 -0500

        Whoops.

    commit b24eff020fd91270f2d41dad99ff733658942172
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Feb 18 17:48:09 2022 -0500

        Include roles and IP addresses in log CSV download.

    commit 57c421062a1a9104f51d5c6c52ca19cfebc0c6cc
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Feb 18 07:22:22 2022 -0500

        More test fiddling.

    commit 28859098d76a993c07259352dd3f17aff9df440d
    Author: Eddie Kohler <[email protected]>
    Date:   Fri Feb 18 06:58:48 2022 -0500

        Whoops.

    commit 548c3423d2e46de0ab8e7f2971c3a9798b2376de
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 17 23:50:51 2022 -0500

        Improve look of error paper pages.

    commit b2b17febf9c2aae5a0f0b3b902e30aabc95c0389
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 17 23:50:28 2022 -0500

        Dewarn.

    commit 1acc10055ea3e6137402b20267e8936ba7367c7d
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 17 23:49:20 2022 -0500

        Quicklinks rendered in script go to the right page.

        Pass page & mode through in a JSON.

    commit f849e94f2b3a6be584000a1a2e4c0cabe69fb46f
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 17 22:50:38 2022 -0500

        More testing.

    commit 31c3144bfa760a6092cc4ac9a2fd28000949b449
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 17 19:59:38 2022 -0500

        Add follow-late-withdrawal feature.

        * Fix withdraw notification: do not notify ALL people who are
          following reviews because that includes authors!!!!!
        * Move withdraw notification to the assigner so that it happens
          whenever it's required.
        * Add `notify` column to withdraw assigner.
        * Improve withdrawal messages.

    commit 2b8c3e758dd55f0383fc3af15b016fb7cf43be93
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 17 19:02:21 2022 -0500

        Correct handling of %ELSE% in mailer.

        Broken in 73844daac226d0ee680188a9b700bf5780eb4f18.

    commit fe625deb8e9e0e307b2834176d8f3ac9d1f32362
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 17 17:58:29 2022 -0500

        Update assignmentset API.

    commit 881e17bfc2eb119842fffea9cd550042dd845533
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 17 15:22:24 2022 -0500

        Fix bad reset of PaperReview::reviewNeedsSubmit when changing round.

        Also remove some dead code: no PaperReviews have negative reviewType.

    commit 315c4e1fc1eb7237013d677b4e19d6448abc2c23
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 17 15:21:31 2022 -0500

        Count delegated reviews when explicitly searching for secondaries.

    commit be4004d4dbb2c61660954db3740bd82856533843
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 17 15:16:01 2022 -0500

        Update tests.

        This exposes a bug or two.

    commit 39c2a545d909b92b8544b6961aa5bbaee4471d00
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 17 15:08:15 2022 -0500

        Types, nits, debugging improvements.

    commit 086054863cd36f5a5c3d61fe21233d2d5c5d29de
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 17 09:47:53 2022 -0500

        Test improvements.

    commit 4f15ff02eed216b5d82eee366f2e65cc01ec29d0
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 17 07:55:59 2022 -0500

        Dewarn, types.

    commit 1a932f541fc2d166d235c60282d1872581dd3c23
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Feb 16 20:44:00 2022 -0500

        Speed up schema reset in test harness.

    commit 9b5ed49c05c04922daa570e4ffca76a9cb9b21fe
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Feb 16 19:49:07 2022 -0500

        Some more tests.

    commit 4587a6ed7ce6281d2e303d3ca16d5781662ec4d2
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Feb 16 14:17:23 2022 -0500

        Types.

    commit 4699df86de87bc7309f06aeb635de12e134848c9
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Feb 16 14:08:17 2022 -0500

        Improve method names.

    commit 7b86cf54733a0dc2f83a2083ed2fd4e96c2058c9
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Feb 15 20:03:32 2022 -0500

        Deprecate Contact::create in favor of Contact->store().

        store() stores [the importable properties of] the current Contact
        in the database, then resets the current Contact's properties with
        the results. This is nicer and may help with primary contacts.

    commit aa05f8875a0341eec9a913e995939eeee7b4d8a3
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Feb 16 11:09:04 2022 -0500

        Fix bug in c203cb2376 found by test.

    commit e451732bb99d9ad1e7fbbabbf065d3d306b1fd39
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Feb 16 10:42:12 2022 -0500

        Add login tests.

    commit 02e78fbc5a5933f43dec45081573855c59caffcf
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Feb 16 10:41:20 2022 -0500

        Remove unused.

    commit f1a6ed1521ee476d31ecbd7e5347d951b237826c
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Feb 16 10:41:12 2022 -0500

        Add Qrequest::make_url for testing purposes.

    commit 1bab3007cf8d44a70af227e6df152150081b3765
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Feb 16 10:36:34 2022 -0500

        Tests: Make test02 runnable without resetting the database.

    commit f335edc6e79613abcf05bb084b6e42c4840adea8
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Feb 16 10:35:06 2022 -0500

        Types, nits.

    commit b8f64fa7d36f7149d7194f75efa82d2fdd7dca67
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Feb 15 20:00:56 2022 -0500

        More test infrastructure.

    commit 1ed861f6a944611fa1d4889566cb7086032a08b6
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Feb 15 17:36:13 2022 -0500

        More test infrastructure.

    commit 6946e628f8e471e9fb5108e5b93e3d8050a8faa6
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Feb 15 11:05:15 2022 -0500

        Update test infrastructure.

    commit 3256e90ed567b92ca180db54f5de0e2eb6b2ad60
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Feb 15 11:04:29 2022 -0500

        Update names, ensure that Contact::make_cdb_email sets cdb_confid correctly.

    commit 892faeaac0534d9700e7ed45b55b90fc245eb73a
    Author: Eddie Kohler <[email protected]>
    Date:   Tue Feb 15 09:32:50 2022 -0500

        Remove Contact::SAVE_ROLES, test that saving roles works.

    commit 996c48140a11db6c933f64cac21bdd0cafa9d785
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Feb 14 16:58:13 2022 -0500

        Style nits

    commit c203cb2376714eedef1abd6b28317ae340ab79f6
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Feb 14 14:40:16 2022 -0500

        Change slicing mechanism for users.

        * Different kinds of slice -- collaborators are in a separate slice.
        * Load sliced users in a more sensible way.
        * Introduce Conf::ensure_cached_user_collaborators() in favor of
          Conf::full_pc_members().

    commit 14bac1e59733452d2deb333f9465b7221753e579
    Author: Eddie Kohler <[email protected]>
    Date:   Mon Feb 14 12:55:02 2022 -0500

        Replace Contact::$sort_order with $pc_index.

    commit f579b2a5db853d99b454652e723727cfd1a22f8d
    Author: Eddie Kohler <[email protected]>
    Date:   Wed Feb 9 12:38:32 2022 -0500

        Nits

    commit ba49cf61c451b85ff597a072da7a49708f78dd16
    Author: Eddie Kohler <[email protected]>
    Date:   Sun Feb 13 22:48:18 2022 -0500

        Types, nits.

    commit 3d60445a27d50ef3c640bd5b195eba7199e79f06
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Feb 12 22:21:11 2022 -0500

        Implement CDB user cache, add Conf::resolve_primary_emails.

        * CDB user cache works by ID and email. All CDB user loads go
          through the cache, which requires occasional invalidation.
        * Conf::resolve_primary_emails tracks emails through the chain
          of primaryContactId references.
        * Some cleanups of $Qreq (=> Qrequest::$main_request).

    commit 6e233aaddfd4906c6adb1ff6d89b5f3d8f861746
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Feb 12 07:52:31 2022 -0500

        Contact roles internals.

        * Don't rely on __isAuthor__ and __isReviewer__ properties. Instead
          introduce `roles_mask`, which says which bits in `roles` are valid.
        * Check that roles are valid as an invariant.
        * PaperInfo and Contact constructors are split into static methods
          with different purposes.
        * Visual fix on disable-user button on profile.

    commit 1e455b4436ae7518dc12bafdb6579fd53b97ba50
    Author: Eddie Kohler <[email protected]>
    Date:   Sat Feb 12 09:23:35 2022 -0500

        Add PaperInfo::make_placeholder.

    commit ba4cb2479432782a070a51ab3f9558d17b3334a7
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 10 22:41:03 2022 -0500

        Waste my time by adapting to a pdftohtml 0.40 bug.

    commit ca741ebddde96efc24bb362f098a76956c2b2f1f
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 10 17:14:52 2022 -0500

        Little style improvement on settings.

    commit 5e4f2e28ae4566cca1d77c718e63e7ee798c30aa
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 10 16:50:12 2022 -0500

        Main paper tables gain horizontal scrolling.

    commit 560d9c64aab2972387a866deaeaaff2b6f0c6cf2
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 10 16:15:29 2022 -0500

        Improve tracks UI when there are no tracks.

    commit a31d73a3bb1088c7da590110a573b10feb51e6e3
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 10 14:04:25 2022 -0500

        Reduce direct calls to Conf::msg.

    commit 07b9df1f0b57e7ee92eb815f92ed311fa694bf91
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 10 13:46:54 2022 -0500

        Remove msg_error references, types on ListAction.

    commit 93e1925afc4913e85ccaa0f8793ad658394834b7
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 10 13:00:22 2022 -0500

        Remove deprecations.

    commit 698e97a635676c5ab42a40cce5b0b225ed816e92
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 10 12:35:53 2022 -0500

        Ftext

    commit 9e9528c12b0cd95aef6da9bd961bad3f1240a423
    Author: Eddie Kohler <[email protected]>
    Date:   Thu Feb 10 12:23:28 2022 -0500

        DocumentInfo uses a MessageSet.

    commit 822302f667e51a42deb60188b1089c4e487a85cd
    Author: Eddie Kohler <eko…
  • Loading branch information
michaelbeale-IL committed Feb 8, 2024
1 parent a4b6554 commit d34fda3
Show file tree
Hide file tree
Showing 464 changed files with 62,272 additions and 40,423 deletions.
78 changes: 78 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
name: Tests

on:
push:
branches: [ master ]
pull_request:
branches: [ master ]

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
php-versions: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0']

steps:
- name: Checkout
uses: actions/checkout@v2

- name: Start mysql
run: |
(echo '[mysqld]'; echo 'default-authentication-plugin=mysql_native_password') | sudo sh -c "cat > /etc/mysql/conf.d/nativepassword.cnf"
sudo systemctl start mysql
mysql -V
- name: Prepare the application
run: |
sudo lib/createdb.sh -u root -proot -c test/options.php --batch
sudo lib/createdb.sh -u root -proot -c test/cdb-options.php --no-dbuser --batch
- name: Set up PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-versions }}
extensions: mbstring, intl, mysqlnd

- name: Install poppler
run: |
sudo apt-get --fix-broken install
sudo apt-get install poppler-utils
- name: Run tests
run: sh test/check.sh

build-18:
runs-on: ubuntu-18.04

strategy:
matrix:
php-versions: ['7.3', '8.0']

steps:
- name: Checkout
uses: actions/checkout@v2

- name: Start mysql
run: |
(echo '[mysqld]'; echo 'default-authentication-plugin=mysql_native_password') | sudo sh -c "cat > /etc/mysql/conf.d/nativepassword.cnf"
sudo /etc/init.d/mysql start
mysql -V
- name: Prepare the application
run: |
sudo lib/createdb.sh -u root -proot -c test/options.php --batch
sudo lib/createdb.sh -u root -proot -c test/cdb-options.php --no-dbuser --batch
- name: Set up PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-versions }}
extensions: mbstring, intl, mysqlnd

- name: Install poppler
run: sudo apt-get install poppler-utils

- name: Run tests
run: sh test/check.sh
8 changes: 4 additions & 4 deletions .htaccess
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

# These directives limit how large a paper can be uploaded.
# post_max_size should be >= upload_max_filesize.
#php_value upload_max_filesize 15M
#php_value post_max_size 20M
php_value upload_max_filesize 15M
php_value post_max_size 20M

# Some pages involve a lot of post variables.
#php_value max_input_vars 4096
php_value max_input_vars 4096

# A large memory_limit helps when sending very large zipped files.
php_value memory_limit 128M
Expand All @@ -18,7 +18,7 @@ AddDefaultCharset UTF-8
DirectoryIndex index.php

# Prevent access to SCM directory, logs, test, README, regardless of case.
RedirectMatch 403 ^.*/(\.[Gg][Ii][Tt].*|\.[Mm][Yy].*|[Rr][Ee][Aa][Dd][Mm][Ee].*|[Ff][Ii][Ll][Ee][Ss][Tt][Oo][Rr][Ee]|[Dd][Oo][Cc][Ss]|[Cc][Oo][Nn][Ff]|[Cc][Oo][Dd][Ee]|[Ll][Oo][Gg][Ss])($|/.*$)
RedirectMatch 403 ^.*/(\..*|[Rr][Ee][Aa][Dd][Mm][Ee].*|[Ff][Ii][Ll][Ee][Ss][Tt][Oo][Rr][Ee]|[Dd][Oo][Cc][Ss]|[Cc][Oo][Nn][Ff]|[Cc][Oo][Dd][Ee]|[Ll][Oo][Gg][Ss])($|/.*$)

# Don't use MultiViews, which can conflict with mod_rewrite suffixless URLs.
Options -MultiViews
Expand Down
11 changes: 10 additions & 1 deletion .phan/config.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@
*/
return (function () {
$config = [
"minimum_target_php_version" => "7.0",
"target_php_version" => "8.1",

// If true, missing properties will be created when
// they are first seen. If false, we'll report an
// error message.
Expand All @@ -48,6 +51,9 @@
"enable_internal_return_type_plugins" => true,
//"enable_extended_internal_return_type_plugins" => true,

//"redundant_condition_detection" => true,
//"unused_variable_detection" => true,

// A list of directories that should be parsed for class and
// method information. After excluding the directories
// defined in exclude_analysis_directory_list, the remaining
Expand Down Expand Up @@ -96,6 +102,7 @@

"exclude_file_list" => [
Config::projectPath(".phan/config.php"),
Config::projectPath("batch/downgradedb.php"),
Config::projectPath("lib/collatorshim.php"),
Config::projectPath("lib/polyfills.php")
],
Expand All @@ -111,7 +118,9 @@

"suppress_issue_types" => [
"PhanUnusedPublicMethodParameter",
"PhanParamReqAfterOpt"
"PhanUnusedVariableValueOfForeachWithKey",
"PhanParamReqAfterOpt", // remove when PHP 7.0 is not supported
"PhanUndeclaredClassAttribute"
],

"plugins" => [
Expand Down
6 changes: 3 additions & 3 deletions .user.ini
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

; These directives limit how large a paper can be uploaded.
; post_max_size should be >= upload_max_filesize.
;upload_max_filesize = 15M
;post_max_size = 20M
upload_max_filesize = 15M
post_max_size = 20M

; Some pages involve a lot of post variables.
;max_input_vars = 4096
max_input_vars = 4096

; A large memory_limit helps when sending very large zipped files.
memory_limit = 128M
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright (c) 2006-2021 Eddie Kohler
Copyright (c) 2006-2022 Eddie Kohler
Copyright (c) 2006-2008 Regents of the University of California

Permission is hereby granted, free of charge, to any person obtaining a
Expand Down
89 changes: 82 additions & 7 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,80 @@
HotCRP NEWS
===========

## Version 3.0b2

* Upgrade notes

* Search change: Search for `re:me:R1`, not `re:me round:R1`.
* PHP 8.0 is supported.
* If you’re upgrading a very old installation, make sure your options
are in `conf/options.php`, not `conf/options.inc`.

* More overhaul of HotCRP’s internals. More pages are rendered through
accumulated partials configured in JSON. Remove global variables. Better
behavior on HEAD methods. Introduce “formatted texts” for messages; these
are strings that start with either `<0>`, meaning what follows is plaintext,
or `<5>`, meaning what follows is HTML.

* Better appearance for many error messages.

* Home

* Report to the PC any scores that are selected by default.
* Highlight when viewing the site as another user.
* Add back-end support for OAuth signin.

* Submissions

* Support fields that become visible when reviews are visible.
* Support real-number submission fields.
* Improve format checker robustness.

* Search

* Add `re:user:R1` (remove `re:user round:R1`).
* Add `rate:good:user` (remove `re:user rate:good`).
* Add `proposal:user`.

* Reviews

* Add support for review fields that appear only on subsets of reviews.
* More color schemes for options.
* Improve accept/decline workflow; send mail on accept as well as decline.
* Support assigning reviews to draft papers.

* Comments

* Support `@mentions` in comments.
* Support comment topic, namely “submission” or “review”. Comments about a
submission are visible to users who can see the submission, whether or
not they can see the reviews.

* Meeting tracker

* IDs of conflicted papers are hidden from a user’s tracker by default.

* Profile

* Better user experience for bulk update.
* Send user notifications more reliably.
* Add UI for disabling a user on their profile page.

* Action log

* Include review unsubmission.
* Include decision settings.

* Settings

* Better display of submission and review fields.
* Internal overhaul.
* Reordering choices in a submission or review field should update existing
submissions (or reviews) accordingly.

* Many other bug fixes, tests, and improvements.


## Version 3.0b1 - 12.Nov.2020

* Upgrade notes
Expand Down Expand Up @@ -89,9 +163,9 @@ HotCRP NEWS

* Search

* Support `[column decorator]` syntax, as in `sort:[lead last]` (sort by
lead last name) or `show:[allpref topics]` (include topic scores in the
preference list) or `show:[lead column]` (show the lead as a column, not
* Support `column[decorator]` syntax, as in `sort:lead[last]` (sort by
lead last name) or `show:allpref[topics]` (include topic scores in the
preference list) or `show:lead[column]` (show the lead as a column, not
a row).
* Support loading entire fields on demand, rather than requiring fields be
partially rendered to Javascript even when not shown.
Expand All @@ -111,10 +185,11 @@ HotCRP NEWS
indexed user’s `#~foo` tag. Use this functionality to compute allotment
votes and approval votes.
* Formulas support `let VAR = VAL in BODY`.
* Support a `#perm:` namespace. Tag a paper `#perm:author-read-review#1`
and that paper’s authors can read its reviews, regardless of other
settings; tag it `#perm:author-read-review#-1` and authors *cannot* read
reviews. Also `#perm:author-write`.
* EXPERIMENTAL: Support a `#perm:` namespace. Tag a paper
`#perm:author-read-review#1` and that paper’s authors can read its
reviews, regardless of other settings; tag it
`#perm:author-read-review#-1` and authors *cannot* read reviews. Also
`#perm:author-write`.

* Formula graphs

Expand Down
Loading

0 comments on commit d34fda3

Please sign in to comment.